From 96d27c7f54c3e4d79fede154fdc5eb492c4ee243 Mon Sep 17 00:00:00 2001 From: Artur Shiriev Date: Mon, 13 Jul 2026 11:58:19 +0300 Subject: [PATCH] fix(tests): drop stale ty:ignore suppressions in circuit breaker tests ty 0.0.59 no longer raises unresolved-attribute on caplog.records access here, leaving the suppression comments dead weight that ty check now flags (and fails on). --- tests/test_circuit_breaker.py | 4 ++-- tests/test_circuit_breaker_sync.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test_circuit_breaker.py b/tests/test_circuit_breaker.py index 1f94f92..528d522 100644 --- a/tests/test_circuit_breaker.py +++ b/tests/test_circuit_breaker.py @@ -311,8 +311,8 @@ async def test_reset_timeout_admits_probe_then_closes(caplog: pytest.LogCaptureF assert response.status_code == HTTPStatus.OK assert handler.calls == 3 # noqa: PLR2004 — 2 failures + 1 probe records = [r for r in caplog.records if r.name == "httpware.circuit_breaker"] - assert any(r.event == "circuit.half_open" for r in records) # ty: ignore[unresolved-attribute] - assert any(r.event == "circuit.closed" for r in records) # ty: ignore[unresolved-attribute] + assert any(r.event == "circuit.half_open" for r in records) + assert any(r.event == "circuit.closed" for r in records) messages = [r.message for r in records] assert any("half-open" in m for m in messages) assert any("closed" in m for m in messages) diff --git a/tests/test_circuit_breaker_sync.py b/tests/test_circuit_breaker_sync.py index a52e6cb..7516d71 100644 --- a/tests/test_circuit_breaker_sync.py +++ b/tests/test_circuit_breaker_sync.py @@ -214,8 +214,8 @@ def test_reset_timeout_admits_probe_then_closes(caplog: pytest.LogCaptureFixture assert response.status_code == HTTPStatus.OK assert handler.calls == 3 # noqa: PLR2004 records = [r for r in caplog.records if r.name == "httpware.circuit_breaker"] - assert any(r.event == "circuit.half_open" for r in records) # ty: ignore[unresolved-attribute] - assert any(r.event == "circuit.closed" for r in records) # ty: ignore[unresolved-attribute] + assert any(r.event == "circuit.half_open" for r in records) + assert any(r.event == "circuit.closed" for r in records) messages = [r.message for r in records] assert any("half-open" in m for m in messages) assert any("closed" in m for m in messages)