# ab79667509a20d65d53fe73928a4ac88c7484a19 ok 1 assisted-by-is-trailer: no Assisted-by metadata ok 2 co-authored-by-is-trailer: no Co-authored-by metadata ok 3 fixes-url: skipping fixes-url # SKIP ok 4 line-after-title: blank line after title ok 5 line-length: line-lengths are valid not ok 6 signed-off-by: Commit must have a "Signed-off-by" trailer () --- { found: '', compare: '===', wanted: '', at: { line: 0, column: 0, body: [ '', 'We currently do not allow callbacks to throw exceptions', '(including the special termination exception used when e.g.', 'tearing down worker threads), because we have no way of', 'generically propagating exceptions through the native layer', 'back to the calling JS code that originally entered the', 'native code.', '', 'However, exceptions may be explicitly or implicitly enabled,', 'e.g. when the target library is a C++ library, or when the', 'compiler was configured to emit unwinding information as', 'part of the code generation process.', '', 'Since this change currently makes no attempt to automatically', "discover the library's level of exception support (which would", 'likely be possible, but platform-dependent), it expects users', 'to actively indicate whether this feature is available in the', 'called library.', '', 'Since this change requires access to native exceptions and', 'most of Node.js is built without support for it, a small part', 'of the code is split out into a new GYP target where exceptions', 'are enabled, and as a part of the Node.js source is also', 'on the path for passing exceptions through, the compiler', 'flags for it are changed to include `-funwind-tables`.', 'The total effect on compiled binary sizes of this patch', 'is approximately 15 kB, which is negligible compared to the', 'total size of the binary.' ] } } ... ok 7 subsystem: valid subsystems [ffi] ok 8 title-format: Title is formatted correctly. ok 9 title-length: Title is <= 50 columns. 0..9 # tests 9 # pass 7 # fail 1 # Please review the commit message guidelines: # https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines npm warn deprecated tap@16.3.10: Versions of tap before v18 are no longer maintained. Please upgrade. npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful. npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported npm warn deprecated @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead npm warn deprecated libtap@1.4.1: This library is no longer used by node-tap, and is unmaintained. npm warn deprecated eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.