quic/blob: dead code for fin?

[martenrichter]

@jasnell can you have a look at

node/lib/internal/blob.js

Line 628 in 54a5095

// If the wakeup was triggered by FIN (EndReadable), the DataQueue

I mean the

if (fin) continue;

I think it does not nothing, as the whole fin stuff.
So it either an artifact, that is now obsolete, that should be removed or something that is important and is just broken.
Do you remember what it was?
@pimterry may be you also have a look.

[pimterry]

Agree, fin does nothing and it's not necessary. I think it could be dropped completely, along with simplifying it out of NotifyPull on the other side.

[jasnell]

fin can be removed. It was there originally just in case but it's proven not to be necessary

[trivenay]

Opened #65315 implementing the removal discussed above — fin is dropped from the iterator, the notifier, and the end-of-stream call site; the reasoning for collapsing the coalescing guard is in the PR description.

Please take a look when you get a chance.

[trivenay]

Fixed by #65315 (my bad on the description wording — "Fixes the dead code identified in ..." broke the auto-close parser :P)