From f8b4ee53a5b5cde56ad63347ab14f6a61f9c8861 Mon Sep 17 00:00:00 2001 From: Samantha Jayasinghe Date: Tue, 17 Nov 2026 11:50:58 +1300 Subject: [PATCH 1/2] Remove fullsend integration (.fullsend folder) Co-Authored-By: Claude Code --- .fullsend/config.yaml | 25 ---------------- .fullsend/harness/code.yaml | 54 --------------------------------- .fullsend/harness/triage.yaml | 33 -------------------- .fullsend/policies/triage.yaml | 55 ---------------------------------- 4 files changed, 167 deletions(-) delete mode 100644 .fullsend/config.yaml delete mode 100644 .fullsend/harness/code.yaml delete mode 100644 .fullsend/harness/triage.yaml delete mode 100644 .fullsend/policies/triage.yaml diff --git a/.fullsend/config.yaml b/.fullsend/config.yaml deleted file mode 100644 index fe722aec6..000000000 --- a/.fullsend/config.yaml +++ /dev/null @@ -1,25 +0,0 @@ -# fullsend per-repo configuration -# https://github.com/fullsend-ai/fullsend -# -# This file configures fullsend for per-repo installation mode. -# See ADR 0033 for details. -version: "1" -roles: - - triage - - coder - - fix -allowed_remote_resources: - - https://raw.githubusercontent.com/fullsend-ai/fullsend/ - - https://raw.githubusercontent.com/fullsend-ai/agents/ -agents: - - name: triage - source: harness/triage.yaml - - name: code - source: harness/code.yaml -authorization: - - provider: owners_file -create_issues: - allow_targets: - repos: - - openshift/osdctl - - fullsend-ai/fullsend diff --git a/.fullsend/harness/code.yaml b/.fullsend/harness/code.yaml deleted file mode 100644 index cd973feda..000000000 --- a/.fullsend/harness/code.yaml +++ /dev/null @@ -1,54 +0,0 @@ -# .fullsend/harness/code.yaml -# -# Composes the upstream fullsend code harness (pinned to agents v0.38.0) and -# adds the local dispatch trigger plus the env overrides the Jira-poll dispatch -# path still needs. v0.38.0 fetches the work item host-side (pre-code-jira.sh) -# and sets ISSUE_URL / FULLSEND_TRACKER, but the reusable-dispatch harness-run -# job does not map every host variable the base env references on the -# pre-computed (jira-poll) matrix path, so those references are overridden here. -base: https://raw.githubusercontent.com/fullsend-ai/agents/7ab05564b3c9c0ab20197e0c8572b5905ffd75ca/harness/code.yaml#sha256=d10044d419789b3b965490a20f3ee58640e8fe3c708afc62b3b7abb3b89224a3 - -trigger: > - event.entity.kind == "work_item" - && ( - (event.transition.kind == "comment_added" - && has(event.transition.comment.command) - && event.transition.comment.command == "/fs-code") - || - (event.transition.kind == "label_changed" - && event.transition.label.name == "ready-to-code" - && event.transition.label.action == "added") - ) - -allowed_remote_resources: [https://raw.githubusercontent.com/fullsend-ai/agents/] - -env: - runner: - FULLSEND_TRACKER: jira - # Placeholder to satisfy the base code harness's ISSUE_NUMBER validation. - # The reusable-dispatch harness-run job doesn't map ISSUE_NUMBER from the - # pre-computed (jira-poll) matrix, so the base harness's "${ISSUE_NUMBER}" - # reference would fail. On the Jira path the issue is identified via - # FULLSEND_WORK_ITEM_URL / ISSUE_URL, not ISSUE_NUMBER. - ISSUE_NUMBER: "0" - CODE_ALLOWED_TARGET_BRANCHES: master - # The base code harness sets GIT_COMMITTER_EMAIL from GIT_BOT_EMAIL, which - # the GitHub code job normally sets from the App bot identity but the - # jira-poll harness-run job does not. Provide a default bot identity. - GIT_BOT_EMAIL: "fullsend[bot]@users.noreply.github.com" - JIRA_USER_EMAIL: "${JIRA_USER_EMAIL}" - JIRA_TOKEN: "${JIRA_TOKEN}" - # Runner env vars don't flow into the OpenShell sandbox automatically; pass - # the Jira credentials through explicitly so the agent can reach Jira Cloud. - sandbox: - # The base code harness references "${ISSUE_NUMBER}" in env.sandbox too (not - # just env.runner), so the sandbox scope needs its own placeholder override. - ISSUE_NUMBER: "0" - # The base code harness sets env.sandbox GIT_COMMITTER_EMAIL from - # "${GIT_BOT_EMAIL}", which isn't set as a host var on the jira-poll path. - # Override with a literal so the sandbox scope resolves. - GIT_COMMITTER_EMAIL: "fullsend[bot]@users.noreply.github.com" - CODE_ALLOWED_TARGET_BRANCHES: master - JIRA_TOKEN: "${JIRA_TOKEN}" - JIRA_USER_EMAIL: "${JIRA_USER_EMAIL}" - JIRA_BASE_URL: "${JIRA_BASE_URL}" diff --git a/.fullsend/harness/triage.yaml b/.fullsend/harness/triage.yaml deleted file mode 100644 index 89e78f5b7..000000000 --- a/.fullsend/harness/triage.yaml +++ /dev/null @@ -1,33 +0,0 @@ -# .fullsend/harness/triage.yaml -# -# Composes the upstream fullsend triage harness (pinned to agents v0.38.0) and -# adds the local dispatch trigger, the Jira credentials the Jira-poll dispatch -# path needs, and a local sandbox policy. v0.38.0 fetches the work item -# host-side (pre-triage-jira.sh) and sets ISSUE_URL / FULLSEND_TRACKER, but -# runner env vars don't flow into the OpenShell sandbox automatically, so the -# Jira credentials are passed through explicitly here. The base sandbox policy -# does not permit egress to Jira Cloud, so policies/triage.yaml is required to -# let the sandbox reach redhat.atlassian.net (read-only) for issue fetching. -base: https://raw.githubusercontent.com/fullsend-ai/agents/7ab05564b3c9c0ab20197e0c8572b5905ffd75ca/harness/triage.yaml#sha256=3aa32e9f66ad6a9b60a75f50d3adc6ae39ebfb425c3928381e019436498bf2aa - -policy: policies/triage.yaml - -trigger: > - event.entity.kind == "work_item" - && event.transition.kind == "comment_added" - && has(event.transition.comment.command) - && event.transition.comment.command == "/fs-triage" - -allowed_remote_resources: [https://raw.githubusercontent.com/fullsend-ai/agents/] - -env: - runner: - FULLSEND_TRACKER: jira - JIRA_USER_EMAIL: "${JIRA_USER_EMAIL}" - JIRA_TOKEN: "${JIRA_TOKEN}" - # Runner env vars don't flow into the OpenShell sandbox automatically; pass - # the Jira credentials through explicitly so the agent can reach Jira Cloud. - sandbox: - JIRA_TOKEN: "${JIRA_TOKEN}" - JIRA_USER_EMAIL: "${JIRA_USER_EMAIL}" - JIRA_BASE_URL: "${JIRA_BASE_URL}" diff --git a/.fullsend/policies/triage.yaml b/.fullsend/policies/triage.yaml deleted file mode 100644 index 4a714acba..000000000 --- a/.fullsend/policies/triage.yaml +++ /dev/null @@ -1,55 +0,0 @@ -version: 1 - -# Sandbox policy for the triage agent (Jira tracker). -# -# Needs Jira Cloud REST API for issue triage and Vertex AI for inference. -# gh excluded from the binary allowlist — only curl is permitted for -# Jira API access. Jira access is read-only: the sandbox only fetches -# issue content (skills/jira-forge teaches GET-only curl commands); -# all mutations (labels, comments, transitions, cross-project create) -# run host-side in pre-triage.sh/post-triage.sh, outside this policy. - -filesystem_policy: - include_workdir: true - read_only: [/usr, /lib, /proc, /dev/urandom, /app, /etc, /var/log] - read_write: [/sandbox, /tmp, /dev/null] -landlock: - compatibility: best_effort -process: - run_as_user: sandbox - run_as_group: sandbox - -network_policies: - vertex_ai: - name: vertex-ai - endpoints: - - host: "api.anthropic.com" - port: 443 - protocol: rest - enforcement: enforce - access: read-write - - host: "*.googleapis.com" - port: 443 - protocol: rest - enforcement: enforce - access: read-write - binaries: - - path: "**/claude" - - path: "**/pi" - - path: "**/node" - - jira_api: - name: jira-api - endpoints: - # Exact host, not "*.atlassian.net": the SSRF pre-tool hook - # (ssrf_pretool.py) rejects wildcards and does exact hostname:port - # matching, so a wildcard fails closed on DNS resolution inside the - # sandbox. The L7 proxy layer accepts wildcards, but the SSRF hook does - # not — so pin the concrete Jira Cloud host. - - host: "redhat.atlassian.net" - port: 443 - protocol: rest - enforcement: enforce - access: read-only - binaries: - - path: "**/curl" From c87d63a57e5959383e0957c93056152e756f170d Mon Sep 17 00:00:00 2001 From: Samantha Jayasinghe Date: Tue, 17 Nov 2026 11:53:32 +1300 Subject: [PATCH 2/2] Remove fullsend GitHub workflows Co-Authored-By: Claude Code --- .github/workflows/fullsend-poll-jira.yml | 114 ----------------------- .github/workflows/fullsend.yaml | 93 ------------------ 2 files changed, 207 deletions(-) delete mode 100644 .github/workflows/fullsend-poll-jira.yml delete mode 100644 .github/workflows/fullsend.yaml diff --git a/.github/workflows/fullsend-poll-jira.yml b/.github/workflows/fullsend-poll-jira.yml deleted file mode 100644 index 218ab7471..000000000 --- a/.github/workflows/fullsend-poll-jira.yml +++ /dev/null @@ -1,114 +0,0 @@ ---- -# fullsend Jira poll -# -# Scheduled workflow that polls Jira for actionable issues/comments and hands -# the resulting dispatches to fullsend's harness for agent execution. -# -# How it works: -# - The `poll` job runs `fullsend poll --input-driver jira-poll`, which writes -# a dispatch record per routed event to dispatches.json, and builds a GHA -# matrix ({include: [...]}) from it. -# - The `harness` job passes that matrix to fullsend's reusable-dispatch -# workflow. When `matrix` is provided, reusable-dispatch skips its own -# routing and runs the harness agents directly against the records -# (see docs/guides/user/jira-integration.md). -# -# Security model: -# - Runs only against this repo's trusted default-branch code (no PR -# checkout), so it is not exposed to "pwn request" style attacks. -# - The fullsend binary is pinned to a specific release and checksum-verified -# before it is given access to the Jira credentials. -# - The reusable-dispatch workflow is pinned to a full commit SHA, and it -# passes user-controlled fields to agents via env vars rather than -# interpolating them into run blocks. -# -# Note: built-in agents cannot yet fully process Jira work-item payloads -# (they expect a GitHub issue number, not a Jira key — fullsend #2264), so -# dispatched agent runs may not complete until that follow-up lands. -name: fullsend Jira poll - -on: - schedule: - - cron: "*/5 * * * *" # every 5 minutes - workflow_dispatch: {} # allow manual runs - -permissions: - actions: write - contents: write - id-token: write - issues: write - packages: read - pull-requests: write - -jobs: - poll: - if: github.repository == 'openshift/osdctl' - runs-on: ubuntu-24.04 - concurrency: - group: fullsend-jira-poll - cancel-in-progress: false - outputs: - matrix: ${{ steps.build-matrix.outputs.matrix }} - steps: - - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - with: - persist-credentials: false - - - name: Install fullsend - env: - GH_TOKEN: ${{ github.token }} - run: | - gh release download v0.43.0 --repo fullsend-ai/fullsend -p 'fullsend_*_linux_amd64.tar.gz' -O - | tar xz - sudo mv fullsend /usr/local/bin/ - - - name: Poll Jira - env: - JIRA_TOKEN: ${{ secrets.JIRA_TOKEN }} - JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }} - JIRA_BASE_URL: ${{ vars.JIRA_BASE_URL }} - TARGET_REPO: ${{ github.repository }} - run: | - fullsend poll \ - --input-driver jira-poll \ - --jira-url "${JIRA_BASE_URL}" \ - --jira-project ROSAENG \ - --jql 'project = ROSAENG AND ( component = "osdctl") AND status not in (Closed, Done)' \ - --target-repo "${TARGET_REPO}" \ - --output dispatches.json \ - --fullsend-dir .fullsend - - - name: Build dispatch matrix - id: build-matrix - run: | - set -euo pipefail - if ! jq -e 'length > 0' dispatches.json > /dev/null 2>&1; then - echo "No dispatches." - echo 'matrix={"include":[]}' >> "${GITHUB_OUTPUT}" - exit 0 - fi - MATRIX=$(jq -c '{include: .}' dispatches.json) - DELIM="MATRIX_$(openssl rand -hex 8)" - { - echo "matrix<<${DELIM}" - printf '%s' "${MATRIX}" - echo - echo "${DELIM}" - } >> "${GITHUB_OUTPUT}" - - harness: - if: github.repository == 'openshift/osdctl' - name: Harness - needs: poll - uses: fullsend-ai/fullsend/.github/workflows/reusable-dispatch.yml@d5f36921ac754705619f38c637ef692873809fbc # v0.43.0 - with: - matrix: ${{ needs.poll.outputs.matrix }} - mint_url: ${{ vars.FULLSEND_MINT_URL }} - gcp_region: ${{ vars.FULLSEND_GCP_REGION }} - jira_base_url: ${{ vars.JIRA_BASE_URL }} - secrets: - FULLSEND_GCP_WIF_PROVIDER: ${{ secrets.FULLSEND_GCP_WIF_PROVIDER }} - FULLSEND_GCP_PROJECT_ID: ${{ secrets.FULLSEND_GCP_PROJECT_ID }} - OTEL_EXPORTER_OTLP_TRACES_HEADERS: ${{ secrets.OTEL_EXPORTER_OTLP_TRACES_HEADERS }} - OTEL_EXPORTER_OTLP_HEADERS: ${{ secrets.OTEL_EXPORTER_OTLP_HEADERS }} - JIRA_TOKEN: ${{ secrets.JIRA_TOKEN }} - JIRA_USER_EMAIL: ${{ secrets.JIRA_USER_EMAIL }} diff --git a/.github/workflows/fullsend.yaml b/.github/workflows/fullsend.yaml deleted file mode 100644 index f90fc2d40..000000000 --- a/.github/workflows/fullsend.yaml +++ /dev/null @@ -1,93 +0,0 @@ -# This file is managed by fullsend. Do not edit it directly. -# Upstream: https://github.com/fullsend-ai/fullsend/blob/main/internal/scaffold/fullsend-repo/.github/workflows/fullsend.yaml ---- -# fullsend shim workflow (per-repo installation mode) -# Routes events to agent workflows via reusable-dispatch.yml. -# All agent execution happens in this repo's context — no external -# config repo is needed. -# -# Security: pull_request_target runs the BASE branch version of this workflow, -# preventing PRs from modifying it to exfiltrate credentials. -# This shim never checks out PR code, so it is not vulnerable to "pwn request" -# attacks. -# -# Routing: this shim forwards the raw event context to reusable-dispatch.yml, -# which determines the stage and runs the agent inline (ADR 62). -# Adding a new stage requires only a job in reusable-dispatch.yml — zero changes to this repo. -# -# Concurrency: per-role cancel-in-progress groups live in reusable-dispatch.yml -# stage jobs with -agent- suffix. Roles operate independently (#2452). -name: fullsend - -permissions: - actions: write - id-token: write - contents: write - issues: write - packages: read - pull-requests: write - -on: - issues: - types: [opened, edited, labeled] - issue_comment: - types: [created] - pull_request_target: - types: [opened, synchronize, ready_for_review, closed, labeled, unlabeled] - pull_request_review: - types: [submitted] - -jobs: - dispatch: - if: >- - github.repository == 'openshift/osdctl' - && ( - github.event_name != 'issue_comment' - || github.event.comment.user.type != 'Bot' - ) - uses: fullsend-ai/fullsend/.github/workflows/reusable-dispatch.yml@5c8aefaf3246b683e80fa9ff0975594a9202d389 # post-v0.43.0 (OWNERS auth, #6051) - with: - event_action: ${{ github.event.action }} - install_mode: per-repo - mint_url: ${{ vars.FULLSEND_MINT_URL }} - gcp_region: ${{ vars.FULLSEND_GCP_REGION }} - runner_image: ubuntu-24.04 - secrets: - FULLSEND_GCP_WIF_PROVIDER: ${{ secrets.FULLSEND_GCP_WIF_PROVIDER }} - FULLSEND_GCP_PROJECT_ID: ${{ secrets.FULLSEND_GCP_PROJECT_ID }} - OTEL_EXPORTER_OTLP_TRACES_HEADERS: ${{ secrets.OTEL_EXPORTER_OTLP_TRACES_HEADERS }} - - stop-fix: - if: >- - github.repository == 'openshift/osdctl' - && github.event_name == 'issue_comment' - && github.event.issue.pull_request - && github.event.comment.user.type != 'Bot' - && github.event.comment.body == '/fs-fix-stop' - && ( - github.event.comment.author_association == 'OWNER' - || github.event.comment.author_association == 'MEMBER' - || github.event.comment.author_association == 'COLLABORATOR' - || github.event.comment.author_association == 'CONTRIBUTOR' - || github.event.comment.user.login == github.event.issue.user.login - ) - runs-on: ubuntu-24.04 - permissions: - contents: read - issues: write - pull-requests: write - steps: - - name: Add fullsend-no-fix label and notify - env: - GH_TOKEN: ${{ github.token }} - PR_NUMBER: ${{ github.event.issue.number }} - REPO: ${{ github.repository }} - run: | - set -euo pipefail - gh label create "fullsend-no-fix" --repo "$REPO" \ - --description "Skip bot-triggered fix agent runs" --color "FBCA04" \ - --force 2>/dev/null || true - gh pr edit "$PR_NUMBER" --repo "$REPO" \ - --add-label "fullsend-no-fix" - gh pr comment "$PR_NUMBER" --repo "$REPO" \ - --body "Fix agent disabled for this PR. Remove the \`fullsend-no-fix\` label or use \`/fs-fix\` to re-engage."