From ada18e42aa48c23ea96766fb3729b0a7e1c44943 Mon Sep 17 00:00:00 2001 From: Wangshu Pang Date: Thu, 6 Aug 2026 07:48:44 +0000 Subject: [PATCH] External-ccm: Remove non-existent imagePullSecrets from CSI controller Deployment The csi-oci-controller Deployment (both the static manifest and the Helm chart template) referenced a secret named image-pull-secret that is never created by any manifest or documented setup step. All images pulled by this Deployment are public (ghcr.io/oracle, registry.k8s.io), so kubelet's mandatory resolution of the missing secret causes FailedToRetrieveImagePullSecret warnings and CrashLoopBackOff on fresh installs. The sibling csi-oci-node DaemonSet pulls the same public images without any imagePullSecrets entry and works fine, confirming this was leftover/vestigial rather than required. Addresses oracle/oci-cloud-controller-manager#510 Signed-off-by: Wangshu Pang --- .../csi/templates/oci-csi-controller-driver.yaml | 2 -- .../container-storage-interface/oci-csi-controller-driver.yaml | 2 -- 2 files changed, 4 deletions(-) diff --git a/manifests/container-storage-interface/csi/templates/oci-csi-controller-driver.yaml b/manifests/container-storage-interface/csi/templates/oci-csi-controller-driver.yaml index f037faa94d..4ae5d0ac66 100644 --- a/manifests/container-storage-interface/csi/templates/oci-csi-controller-driver.yaml +++ b/manifests/container-storage-interface/csi/templates/oci-csi-controller-driver.yaml @@ -145,8 +145,6 @@ spec: emptyDir: {} dnsPolicy: ClusterFirst hostNetwork: true - imagePullSecrets: - - name: image-pull-secret restartPolicy: Always schedulerName: default-scheduler serviceAccount: csi-oci-{{ if .Values.customHandle }}{{ .Values.customHandle }}-{{ end }}node-sa diff --git a/manifests/container-storage-interface/oci-csi-controller-driver.yaml b/manifests/container-storage-interface/oci-csi-controller-driver.yaml index ff0710add1..4d879a3853 100644 --- a/manifests/container-storage-interface/oci-csi-controller-driver.yaml +++ b/manifests/container-storage-interface/oci-csi-controller-driver.yaml @@ -139,8 +139,6 @@ spec: emptyDir: {} dnsPolicy: ClusterFirst hostNetwork: true - imagePullSecrets: - - name: image-pull-secret restartPolicy: Always schedulerName: default-scheduler serviceAccount: csi-oci-node-sa