Skip to content

Improvements #1

Description

@ankitdaf

Line 8, 19 : replace the [] with pass

Generally, isn't it a bit inefficient ?

You are picking one avi file, and then for each avi file you are iterating through the entire subtitles directory

Assuming n files and n subtitles, you are doing the loops n*n times, whereas you could be doing it n + n times, n for avi and n for .srt

Is that possible ?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions