Repository navigation
Replies: 7 comments
|
+1 for this. We use a self-hosted Bitbucket Data Center instance on a custom internal domain, so this is currently the main thing keeping us from being able to use the Bitbucket integration fully. For us, the most useful initial scope would be authenticating against a custom Data Center instance and supporting the normal PR workflow: create/view PRs, diffs, comments, reviewers, and merge/decline. I'd also be happy to help test this against a real Data Center instance, or help with the implementation if that's useful. |
|
+1, we run Bitbucket Data Center too. (I opened #14592 for this by mistake; it was closed as a duplicate of this thread, so moving the details here.) What differs from Cloud, for whoever picks this up:
A read-only first step (list / view pull requests, branch PR status) seems like a reasonable starting scope, with actions (comment, approve, merge) after that. Related: today a Data Center remote is classified as Bitbucket and its PR traffic goes to |
|
I've implemented this on a fork and would like maintainer sign-off on direction and scope before opening a PR: https://github.com/OhadC/t3code/tree/feat/bitbucket-data-center Scope (tested against a real Data Center instance):
Size: about 6.9k added lines, roughly half of them tests. Most of it is new adapter files beside the Cloud ones. Shared changes are small: the contract enum value, URL parsing, provider registration, and the settings form. Splitting: happy to send it as a stack if that's easier to review:
Or I can start with the read-only part, as suggested above. Relation to #14593: it marks these hosts unsupported until Data Center support exists. This work replaces that by routing them to the Data Center adapter. If #14593 lands first I'll rebase on it. Known limitation: one Data Center instance per server, and the host needs a Does this direction and scope work for you, and do you prefer one PR or the stack? |
|
Status update: the Data Center support is now up as three draft PRs on current
The scope is the one described above, rebuilt on the per-host package architecture. Saved credentials are part of #18241 rather than a separate layer. All three were exercised against a real Data Center instance, with screenshots in the PRs. GitHub can't base an upstream PR on a fork branch, so all three target @juliusmarminge, does this direction and scope work for you? The PRs stay in draft until there's a sign-off here. |
|
+1 from our side too. We run Bitbucket Data Center 9.4.9 and are currently running into the issue that the "watch PR" feature is used but doesn't really work with it. Would be really cool to have this working. Also happy to help if help is needed. |
|
@juliusmarminge Could your dot triage this proposal for scope approval? I’d like to help with Bitbucket Data Center support, starting with instance authentication and read-only PR browsing. We use it at work, so I can help test against a real instance. Would that scope be acceptable, perhaps building on @OhadC’s existing work? |
|
For now, my solution is adapter proxy that adapt between bb dc and cloud. |
Uh oh!
There was an error while loading. Please reload this page.
Currently t3code only supports BitBucket Cloud. I am trying to use t3code at work, but we use BitBucket data center so the BitBucket integration does not work since it uses different endpoints.
All reactions