From e2306ab468130f97fa6ea8dd6862ed75706b30a1 Mon Sep 17 00:00:00 2001 From: Akshat Mittal Date: Fri, 9 Oct 2026 16:47:13 +0000 Subject: [PATCH] fix(facade): report TradeHelperFacet sellAmount in token quanta getAllOpenTradesForRToken returned DutchTrade.sellAmount(), a {sellTok} D18 value, next to bidAmount in {qBuyTok}. Use lot() so both amounts are in token quanta, matching the amount createTrustedFill uses. Amp-Thread-ID: https://ampcode.com/threads/T-01a1218b-431d-74f9-94c8-a47fdaadb450 --- contracts/facade/facets/TradeHelperFacet.sol | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contracts/facade/facets/TradeHelperFacet.sol b/contracts/facade/facets/TradeHelperFacet.sol index f06cda81e..8bbb1717f 100644 --- a/contracts/facade/facets/TradeHelperFacet.sol +++ b/contracts/facade/facets/TradeHelperFacet.sol @@ -26,8 +26,8 @@ contract TradeHelperFacet { address tradeAddress; address sellToken; address buyToken; - uint256 sellAmount; - uint256 bidAmount; + uint256 sellAmount; // {qSellTok} + uint256 bidAmount; // {qBuyTok} } function getAllOpenTradesForRToken(RTokenP1 rToken, uint48 timestamp) @@ -75,7 +75,7 @@ contract TradeHelperFacet { tradeAddress: address(trade), sellToken: address(trade.sell()), buyToken: address(trade.buy()), - sellAmount: trade.sellAmount(), + sellAmount: trade.lot(), bidAmount: trade.bidAmount(timestamp == 0 ? uint48(block.timestamp) : timestamp) }); }