Commit 4230bc1
committed
mini-racer: guard the sandbox status check on riscv64
The riscv64 build_dll job got through every prior GCC-compat and gn-arg
fix and 2155/2176 of the way through the ninja build, then failed
compiling mini_racer's own exports.cc:
../../custom_deps/mini_racer/exports.cc:180:18: error:
'IsSandboxConfiguredSecurely' is not a member of 'v8::V8'
v8::V8::IsSandboxConfiguredSecurely() (include/v8-initialization.h) is
declared only under V8_ENABLE_SANDBOX, which V8 (BUILD.gn/gni/v8.gni)
defaults on only where pointer compression defaults on: v8_current_cpu
== "arm64", "x64" or "loong64". riscv64 isn't in that list and this
port sets no gn arg to force it, so the sandbox -- and the API exports.cc
calls unconditionally -- doesn't exist there, unlike on every
architecture upstream's own build.yml actually ships wheels for
(x64/arm64), where it's on by default.
Patch exports.cc to guard the call the same way v8-initialization.h
guards the declaration, reporting "not securely configured" when
there's no sandbox at all, same as a fallback insecure one would.1 parent de51c8f commit 4230bc1
1 file changed
Lines changed: 56 additions & 0 deletions
Lines changed: 56 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
0 commit comments