Skip to content

Commit b81c83a

Browse files
committed
wandb: accept wandb-symon in the riscv64 binary check
wandb 0.31.0 renamed the bundled Rust sidecar from wandb-xpu to wandb-symon. The wheel built and passed its import test, but the post-build check still required wandb/bin/wandb-xpu. Require exactly one of the two names and verify it like the other binaries.
1 parent 918eb1b commit b81c83a

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

‎.github/workflows/build-wandb.yml‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,10 @@ jobs:
112112
INTERP = "/lib/ld-linux-riscv64-lp64d.so.1"
113113
expected = {
114114
"wandb/bin/wandb-core",
115-
"wandb/bin/wandb-xpu",
116115
"wandb/bin/librust_parquet_ffi.so",
117116
}
117+
# wandb-xpu was renamed wandb-symon in 0.31.0.
118+
sidecars = ("wandb/bin/wandb-xpu", "wandb/bin/wandb-symon")
118119
119120
def interpreter(blob):
120121
phoff = int.from_bytes(blob[0x20:0x28], "little")
@@ -132,8 +133,11 @@ jobs:
132133
for whl in sys.argv[1:]:
133134
with zipfile.ZipFile(whl) as zf:
134135
names = set(zf.namelist())
135-
assert expected <= names, sorted(expected - names)
136-
for name in sorted(expected):
136+
present = {n for n in sidecars if n in names}
137+
assert len(present) == 1, sorted(present)
138+
required = expected | present
139+
assert required <= names, sorted(required - names)
140+
for name in sorted(required):
137141
blob = zf.read(name)
138142
assert blob[:4] == b"\x7fELF", (name, blob[:4])
139143
machine = int.from_bytes(blob[18:20], "little")

0 commit comments

Comments
 (0)