From dd847eb12854261d244fc19a1fc058da90c8bd5f Mon Sep 17 00:00:00 2001 From: Leo Arnold Date: Wed, 8 Jul 2026 18:53:46 +0200 Subject: [PATCH] Add 'logger' as dependency in gemspec Follow up to #399. --- Gemfile | 4 ---- lograge.gemspec | 5 +++++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Gemfile b/Gemfile index b4e778a3..85c26f57 100644 --- a/Gemfile +++ b/Gemfile @@ -18,8 +18,4 @@ group :test do gem 'jrjackson', '~> 0.2.9', platforms: :jruby gem 'lines' gem 'thread_safe' - - # Since Ruby-3.4 vendored stdlib logger warns that it will be removed - # Since Ruby-3.5 logger is extracted into a standalone gem - gem 'logger' end diff --git a/lograge.gemspec b/lograge.gemspec index b8f02e51..752ae795 100644 --- a/lograge.gemspec +++ b/lograge.gemspec @@ -25,6 +25,7 @@ Gem::Specification.new do |s| # base64, benchmark, bigdecimal and mutex_m were extracted from the default # gems in Ruby 3.4/4.1; older Rails releases still `require` them, and JRuby # (which targets Ruby 3.4) does not bundle them, so declare them explicitly. + # See: https://stdgems.org s.add_development_dependency 'base64' s.add_development_dependency 'benchmark' s.add_development_dependency 'bigdecimal' @@ -38,6 +39,10 @@ Gem::Specification.new do |s| s.add_dependency 'actionpack', '>= 4' s.add_dependency 'activesupport', '>= 4' + # logger was also extracted from the default gems (Ruby 3.5), but lograge + # `require`s it at runtime, so it is a runtime rather than a development + # dependency. + s.add_dependency 'logger' s.add_dependency 'railties', '>= 4' s.add_dependency 'request_store', '~> 1.0' end