From eb30fce2b8cd9d802fcb505c69b9f068e5dacada Mon Sep 17 00:00:00 2001 From: fi3ework Date: Sun, 20 Sep 2026 18:52:13 +0800 Subject: [PATCH 1/2] test(vscode): drop the wall-clock retry assertion from the registry harness The continuous-interruption test asserted `attempts > 1` inside a 50ms budget with 5ms retry delays. The suite runs inside the extension host during activation, so one stalled retry delay can outlast the budget and leave a correct loop at attempts=1 (Windows E2E, run 35502494622). Retrying is already proven by the interrupted-window test; this test's own point is that continuous interruption ends in a timeout. --- .../e2e/lint/suite/registry-harness.test.ts | 24 ++++++++----------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/packages/vscode/e2e/lint/suite/registry-harness.test.ts b/packages/vscode/e2e/lint/suite/registry-harness.test.ts index e6536d9..e30ceee 100644 --- a/packages/vscode/e2e/lint/suite/registry-harness.test.ts +++ b/packages/vscode/e2e/lint/suite/registry-harness.test.ts @@ -33,23 +33,19 @@ suite('VS Code test harness fail-closed guards', function () { }); test('continuous interruption times out instead of passing partially', async () => { - let attempts = 0; await assert.rejects( - waitForConsecutiveSuccessfulProbeWindows( - async () => { - attempts += 1; - return false; - }, - { - consecutiveSuccessfulWindows: 2, - timeoutMs: 50, - retryDelayMs: 5, - description: 'the continuously interrupted injected probe', - }, - ), + waitForConsecutiveSuccessfulProbeWindows(async () => false, { + consecutiveSuccessfulWindows: 2, + timeoutMs: 50, + retryDelayMs: 5, + description: 'the continuously interrupted injected probe', + }), /Timed out.*interruptedWindows=/, ); - assert.ok(attempts > 1, 'The probe should retry readiness windows'); + // Deviation from upstream: no `attempts > 1` assertion. Retrying is + // already proven by the interrupted-window test above, and this suite runs + // inside the extension host during activation, where one stalled 5ms retry + // delay can outlast the 50ms budget and leave a correct loop at attempts=1. }); test('a non-settling probe window is bounded by the hard deadline', async () => { From 611db25a87d774250b90edb9f8d877216474ad7e Mon Sep 17 00:00:00 2001 From: fi3ework Date: Mon, 21 Sep 2026 11:23:10 +0800 Subject: [PATCH 2/2] test(vscode): exercise the delayed-retry branch from the interrupted-window test The interrupted-window test now uses a 5ms retry delay, so the positive delay branch stays covered by an exact attempt count under a 1000ms budget that a stalled runner cannot exhaust. --- packages/vscode/e2e/lint/suite/registry-harness.test.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/vscode/e2e/lint/suite/registry-harness.test.ts b/packages/vscode/e2e/lint/suite/registry-harness.test.ts index e30ceee..44b6973 100644 --- a/packages/vscode/e2e/lint/suite/registry-harness.test.ts +++ b/packages/vscode/e2e/lint/suite/registry-harness.test.ts @@ -21,7 +21,10 @@ suite('VS Code test harness fail-closed guards', function () { { consecutiveSuccessfulWindows: 2, timeoutMs: 1_000, - retryDelayMs: 0, + // Deviation from upstream (0): a positive delay so the delayed-retry + // branch is exercised here, with a budget that a stalled runner cannot + // exhaust across three 5ms waits. + retryDelayMs: 5, description: 'the injected readiness sequence', }, );