diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/components/create-base-modal/create-base-modal.tsx b/apps/sim/app/workspace/[workspaceId]/knowledge/components/create-base-modal/create-base-modal.tsx index 25b37a670b9..1737bf7e41e 100644 --- a/apps/sim/app/workspace/[workspaceId]/knowledge/components/create-base-modal/create-base-modal.tsx +++ b/apps/sim/app/workspace/[workspaceId]/knowledge/components/create-base-modal/create-base-modal.tsx @@ -9,7 +9,6 @@ import { ChipInput, ChipModal, ChipModalBody, - ChipModalError, ChipModalField, ChipModalFooter, ChipModalHeader, @@ -23,7 +22,7 @@ import { createLogger } from '@sim/logger' import { getErrorMessage } from '@sim/utils/errors' import { X } from 'lucide-react' import { useParams } from 'next/navigation' -import { type FieldErrors, useForm } from 'react-hook-form' +import { useForm } from 'react-hook-form' import { z } from 'zod' import type { StrategyOptions } from '@/lib/chunkers/types' import { KNOWLEDGE_BASE_DESCRIPTION_MAX_LENGTH } from '@/lib/knowledge/constants' @@ -119,11 +118,6 @@ const FormSchema = z type FormInputValues = z.input type FormValues = z.output -interface SubmitStatus { - type: 'success' | 'error' - message: string -} - export const CreateBaseModal = memo(function CreateBaseModal({ open, onOpenChange, @@ -134,11 +128,10 @@ export const CreateBaseModal = memo(function CreateBaseModal({ const createKnowledgeBaseMutation = useCreateKnowledgeBase(workspaceId) const deleteKnowledgeBaseMutation = useDeleteKnowledgeBase(workspaceId) - const [submitStatus, setSubmitStatus] = useState(null) const [files, setFiles] = useState([]) const [fileError, setFileError] = useState(null) - const { uploadFiles, isUploading, uploadProgress, uploadError, clearError } = useKnowledgeUpload({ + const { uploadFiles, isUploading, uploadProgress, clearError } = useKnowledgeUpload({ workspaceId, }) @@ -178,7 +171,6 @@ export const CreateBaseModal = memo(function CreateBaseModal({ useEffect(() => { if (open) { - setSubmitStatus(null) setFileError(null) setFiles([]) reset({ @@ -231,18 +223,7 @@ export const CreateBaseModal = memo(function CreateBaseModal({ const isSubmitting = createKnowledgeBaseMutation.isPending || deleteKnowledgeBaseMutation.isPending || isUploading - const onInvalid = (formErrors: FieldErrors) => { - const firstMessage = Object.values(formErrors).find( - (fieldError) => typeof fieldError?.message === 'string' - )?.message - toast.error( - typeof firstMessage === 'string' ? firstMessage : 'Please fix the highlighted fields' - ) - } - const onSubmit = async (data: FormValues) => { - setSubmitStatus(null) - try { const strategyOptions: StrategyOptions | undefined = data.strategy === 'regex' && data.regexPattern @@ -289,7 +270,8 @@ export const CreateBaseModal = memo(function CreateBaseModal({ } catch (deleteError) { logger.error('Failed to delete orphaned knowledge base:', deleteError) } - throw uploadError + toast.error(getErrorMessage(uploadError, 'Failed to upload files')) + return } } @@ -298,10 +280,6 @@ export const CreateBaseModal = memo(function CreateBaseModal({ handleClose(false) } catch (error) { logger.error('Error creating knowledge base:', error) - setSubmitStatus({ - type: 'error', - message: getErrorMessage(error, 'An unknown error occurred'), - }) } } @@ -309,7 +287,7 @@ export const CreateBaseModal = memo(function CreateBaseModal({ handleClose(false)}>Create Knowledge Base -
+