Skip to content

Skops needs to set trusted types to deserialize sklearn KNN model #498

Description

@WeichenXu123

Skops needs to set trusted types to deserialize sklearn KNN model:

Repro code:

import skops.io
import sklearn.neighbors as knn
from sklearn import datasets
import pandas as pd

iris = datasets.load_iris()
X = iris.data
y = iris.target
X_df = pd.DataFrame(X, columns=iris.feature_names)
X_df = X_df.iloc[:, :2]  # we only take the first two features.
y_series = pd.Series(y)

knn_model = knn.KNeighborsClassifier()
knn_model.fit(X_df, y_series)

save_path = "/tmp/knn_model1.sko"
skops.io.dump(knn_model, save_path)

# If removing `trusted` param, loading fails.
# but the 2 types are sklearn builtin types, so that it should not ask user to set `trusted` param
skops.io.load(save_path, trusted=["sklearn.metrics._dist_metrics.EuclideanDistance64","sklearn.neighbors._kd_tree.KDTree"])

The 2 types ["sklearn.metrics._dist_metrics.EuclideanDistance64","sklearn.neighbors._kd_tree.KDTree"] are sklearn builtin types,
so that it should not ask user to set trusted param.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions