From b974e319017cbbc73936c74a011ba72d1cdfe372 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=ABl=20R=2E=20Langlois?= Date: Mon, 16 Nov 2026 14:48:42 -0500 Subject: [PATCH] fix(installer): name System32's tar on Windows, not whatever PATH offers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit An editor started from a Git Bash terminal hands its extension host that shell's PATH, where GNU tar sits ahead of System32. extractArchive asked for the bare name "tar", so GNU tar read the staging path C:\...\download.zip as a remote host:path - /usr/bin/tar: Cannot connect to C: resolve failed, exit 128 - and OpenCode V2 never launched: the agent card read "launch prerequisite unavailable". GNU tar cannot open a .zip at all either, and runtime-resolver.ts serves .zip on Windows, so bsdtar was the only tool that could do the job whatever the colon did. tarCommand(platform, env) resolves the tool instead of letting PATH pick it: the bare name everywhere else, SystemRoot (SystemDrive, then C:) 's System32\tar.exe on Windows - bsdtar, which reads .zip and .tar.gz and takes Windows paths, and ships with Windows 10 1803+. A tool that won't start now reports the path it tried. vitest pins the resolution and, on a Windows host, proves what it resolves really reports itself as bsdtar. Signed-off-by: Joël R. Langlois --- CHANGELOG.md | 9 +++++ src/orchestrator/stores/binary-installer.ts | 34 +++++++++++++++---- test/binary-installer.test.ts | 37 +++++++++++++++++++++ 3 files changed, 74 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8ab42864..78e017ca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,14 @@ # Changelog +## Unreleased + +- **Installing OpenCode V2 on Windows stops failing at `tar exited 128`.** The + installer asked PATH for `tar`, and an editor started from a Git Bash shell + hands its extension host a PATH where GNU tar comes first: it read the + staging path `C:\…\download.zip` as `host:path` and died. It now names + System32's `tar.exe` — bsdtar, which reads `.zip` and takes Windows paths — + and a tool that won't start reports the path it tried. + ## 0.90.4 — 2026-11-15 Bug fixes: local-file links in agent answers open in the editor, picker rows diff --git a/src/orchestrator/stores/binary-installer.ts b/src/orchestrator/stores/binary-installer.ts index d2298323..d55a6f50 100644 --- a/src/orchestrator/stores/binary-installer.ts +++ b/src/orchestrator/stores/binary-installer.ts @@ -107,13 +107,35 @@ export function isBinaryInstalled( return pathExists(resolvedBinaryPath(cacheRoot, distribution, version, cmd)); } -/** Shells out to the system `tar` — GNU tar (Linux) / bsdtar (macOS, and - * Windows 10 1803+ ships tar.exe as bsdtar too, which also reads .zip) — - * rather than adding a zip/tar dependency for a format set every platform - * this extension targets already covers natively. */ +/** Which archive tool to run, rather than adding a zip/tar dependency for a + * format set every platform this extension targets covers natively: GNU tar + * on Linux, bsdtar on macOS. + * + * On Windows the bare name is not enough — it resolves to whichever tar the + * process that started the editor happened to put first on PATH. A shell + * like Git Bash puts its own GNU tar there, and GNU tar reads a Windows + * path's drive letter as a remote host (`Cannot connect to C: resolve + * failed`, exit 128) and cannot open a .zip at all, which is the format the + * Windows runtime archives are served as (runtime-resolver.ts). System32's + * tar is bsdtar — it reads .zip and .tar.gz and takes Windows paths — and + * Windows 10 1803+ ships it, so name it outright. + * + * Built with backslashes, not `join`: this names a Windows path whatever + * host runs the code that asks. */ +export function tarCommand( + platform: NodeJS.Platform = process.platform, + env: Readonly> = process.env, +): string { + if (platform !== "win32") return "tar"; + const root = (env.SystemRoot ?? `${env.SystemDrive ?? "C:"}\\Windows`).replace(/[\\/]+$/, ""); + return `${root}\\System32\\tar.exe`; +} + +/** Extracts into the staging dir with `tarCommand`'s tool. */ async function extractArchive(archivePath: string, destDir: string): Promise { - const answer = await runToExit("tar", ["-xf", archivePath, "-C", destDir], { env: process.env }); - if (answer === null) throw new Error("tar could not be run"); + const tar = tarCommand(); + const answer = await runToExit(tar, ["-xf", archivePath, "-C", destDir], { env: process.env }); + if (answer === null) throw new Error(`${tar} could not be run`); if (answer.code !== 0) throw new Error(`tar exited ${answer.code}: ${answer.stderr.trim()}`); } diff --git a/test/binary-installer.test.ts b/test/binary-installer.test.ts index 0f8dd242..d7eef099 100644 --- a/test/binary-installer.test.ts +++ b/test/binary-installer.test.ts @@ -11,8 +11,10 @@ import { ChecksumMismatch, installBinary, parseSha256, + tarCommand, type BinaryInstallSpec, } from "../src/orchestrator/stores/binary-installer"; +import { runToExit } from "../src/orchestrator/process-tree"; const BYTES = Buffer.from("#!/bin/sh\necho agent\n"); const DIGEST = createHash("sha256").update(BYTES).digest("hex"); @@ -52,6 +54,41 @@ describe("parseSha256", () => { }); }); +describe("tarCommand — which tar the extract runs", () => { + // What this pins: an editor started from a shell that put its own GNU tar + // (Git Bash) ahead of System32 extracted nothing at all. GNU tar reads a + // Windows path's drive letter as a remote host — `Cannot connect to C: + // resolve failed`, exit 128 — and cannot open the .zip a Windows runtime + // archive is served as. + it("on Windows it is System32's tar, named outright so PATH cannot beat it", () => { + expect(tarCommand("win32", { SystemRoot: "C:\\Windows" })).toBe("C:\\Windows\\System32\\tar.exe"); + }); + + it("it follows the Windows root the environment names, never a hardcoded C:", () => { + expect(tarCommand("win32", { SystemRoot: "D:\\win" })).toBe("D:\\win\\System32\\tar.exe"); + expect(tarCommand("win32", { SystemDrive: "E:" })).toBe("E:\\Windows\\System32\\tar.exe"); + expect(tarCommand("win32", {})).toBe("C:\\Windows\\System32\\tar.exe"); + }); + + it("a root that already ends in a separator does not double it", () => { + expect(tarCommand("win32", { SystemRoot: "C:\\Windows\\" })).toBe("C:\\Windows\\System32\\tar.exe"); + }); + + it("elsewhere the bare name is enough — there is one tar per platform", () => { + for (const platform of ["linux", "darwin", "freebsd"] as const) { + expect(tarCommand(platform, {})).toBe("tar"); + } + }); + + it.runIf(process.platform === "win32")( + "what this host resolves really is bsdtar — the tool that reads .zip", + async () => { + const answer = await runToExit(tarCommand(), ["--version"], { env: process.env }); + expect(answer?.stdout).toMatch(/bsdtar/); + }, + ); +}); + describe("installBinary — the published digest", () => { it("a download matching its digest installs", async () => { const installed = await installBinary(root, spec("match", DIGEST));