Repository navigation
Commit 897da79
fix: make the release dispatch ask which bump it wants (ENG-9233)
[ENG-9233](https://stacklet.atlassian.net/browse/ENG-9233)
What
----
- Opens the caller's `bump` dropdown on `(choose one)` rather than defaulting
to `patch`, so a dispatch has to answer the question. The called workflow
already rejects anything but the three real values, so the placeholder needs
no new validation.
- Drops the step that required a first release to be a major bump.
- Updates the README to match, in the prose about refusals and in the caller
block it offers for copying.
Why
----
`patch` was a poor default on a dispatch that cannot be taken back. On a
repository with no tags it opens at `v0.0.1`, and immutable releases burn that
name for good. On any later release it quietly ships a patch for work that
earned a minor, which nothing caught, because the guard only ever looked at
first releases.
Asking the question fixes both, and it fixes them at the point where the
default was wrong rather than downstream of it. The guard can then go. A
repository that explicitly asks for a patch on an empty tag history means
`v0.0.1`, and a minor bump climbs out of it, so there is nothing left worth
refusing. Whether a repository opens at `v0.0.1`, `v0.1.0` or `v1.0.0` is its
own call, and `cut-release.yml` no longer holds a view on it.
Testing
----
- [x] `just lint` passes here and in the five module repositories.
- [x] `uvx zizmor@1.23.1 -v --gh-token=... .github/workflows/` reports no
findings, with the five online audits scheduled rather than skipped.
- [x] Ran the bump check against `(choose one)`, `patch`, `minor`, `major`,
`Patch`, empty and `majorly`. Only the three lowercase values pass, so
the placeholder stops a run the same way any other unrecognised bump
does.
- [x] Parsed each caller to confirm the placeholder survives YAML as the
literal `(choose one)` and that no `default` key remains.
- [ ] After merge, dispatch Release here and confirm the dropdown opens on
`(choose one)` and that submitting it fails at the bump check.
- [ ] Dispatch Release with a `minor` bump and confirm `v1.1.0` publishes
against `v1.0.0` as previous.
Docs
----
The README's account of the refusals now covers the placeholder, and says what
each bump opens at on a repository with no tags rather than naming one of them
as required.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 6fa4d7c commit 897da79
3 files changed
Lines changed: 23 additions & 20 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
53 | 58 | | |
54 | 59 | | |
55 | 60 | | |
| |||
111 | 116 | | |
112 | 117 | | |
113 | 118 | | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | 119 | | |
129 | 120 | | |
130 | 121 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
8 | 12 | | |
9 | 13 | | |
10 | | - | |
11 | 14 | | |
| 15 | + | |
12 | 16 | | |
13 | 17 | | |
14 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
67 | 71 | | |
68 | 72 | | |
69 | | - | |
70 | 73 | | |
| 74 | + | |
71 | 75 | | |
72 | 76 | | |
73 | 77 | | |
| |||
95 | 99 | | |
96 | 100 | | |
97 | 101 | | |
98 | | - | |
99 | | - | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
100 | 108 | | |
101 | 109 | | |
102 | 110 | | |
0 commit comments