Repository navigation
Commit d351ecc
fix: let a first release open at v0.1.0 (ENG-9233)
[ENG-9233](https://stacklet.atlassian.net/browse/ENG-9233)
What
----
- Narrows the first-release guard from "the bump has to be major" to "the bump
cannot be patch", so a repository with no tags can open at `v0.1.0` as well
as at `v1.0.0`.
- Updates the `bump` input description and the README to match, both in this
repository's own caller and in the block the README offers for copying.
Why
----
The guard exists to stop a first release landing `v0.0.1`, which immutable
releases make permanent. Refusing `patch` covers that on its own. Refusing
everything except `major` also blocks `minor`, which lands `v0.1.0` and is how
a project opens when it is not ready to call its interface settled. The
workflow was deciding a question that belongs to the repository calling it.
This surfaced while versioning the five module repositories for this ticket.
Two of them have no tags, so the guard forced them to `v1.0.0`, and the other
three were then argued up to match for consistency. Only the first step of
that was the tooling's to make.
Testing
----
- [x] `just lint` passes.
- [x] `uvx zizmor@1.23.1 -v --gh-token=... .github/workflows/` reports no
findings, with the five online audits scheduled rather than skipped.
- [x] Walked the guard against each bump at the `0.0.0` baseline: `patch` is
refused, `minor` and `major` pass. Confirmed against semver that those
land `v0.0.1`, `v0.1.0` and `v1.0.0` respectively, so the refused case is
the only one worth refusing.
- [x] Confirmed the bump check runs before this step, so comparing against the
literal `patch` cannot be defeated by a mixed-case input the way a raw
workflow expression otherwise would.
- [ ] After merge, dispatch Release here with a `minor` bump and confirm
`v1.1.0` publishes against `v1.0.0` as previous.
- [ ] The first dispatch on `terraform-aws-stacklet-cur-setup` exercises a
`minor` bump from an empty tag history against the real guard.
Docs
----
The README's description of the refusals now says the first release cannot be a
patch, and names what minor and major open at.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent 6fa4d7c commit d351ecc
3 files changed
Lines changed: 16 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
123 | 125 | | |
124 | | - | |
125 | | - | |
| 126 | + | |
| 127 | + | |
126 | 128 | | |
127 | 129 | | |
128 | 130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | | - | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
100 | 101 | | |
101 | 102 | | |
102 | 103 | | |
0 commit comments