chore: drop context manager protocol from StackletContext

### what

drop the context manager protocol from StackletContext

### why

it's not used for anything and just makes the code more indented

### testing

unit tests and local testing

### docs

n/a

Author: albertodonato

stacklet/client/platform/cli.py

@@ -268,14 +268,14 @@ def show(ctx):
     """
     Show your config
     """
-    with StackletContext(ctx.obj["config"], ctx.obj["raw_config"]) as context:
-        fmt = Formatter.registry.get(ctx.obj["output"])()
-        if os.path.exists(os.path.expanduser(StackletContext.DEFAULT_ID)):
-            with open(os.path.expanduser(StackletContext.DEFAULT_ID), "r") as f:
-                id_details = jwt.decode(f.read(), options={"verify_signature": False})
-            click.echo(fmt(id_details))
-            click.echo()
-        click.echo(fmt(context.config.to_json()))
+    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
+    fmt = Formatter.registry.get(ctx.obj["output"])()
+    if os.path.exists(os.path.expanduser(StackletContext.DEFAULT_ID)):
+        with open(os.path.expanduser(StackletContext.DEFAULT_ID), "r") as f:
+            id_details = jwt.decode(f.read(), options={"verify_signature": False})
+        click.echo(fmt(id_details))
+        click.echo()
+    click.echo(fmt(context.config.to_json()))
 
 
 @cli.command(short_help="Login to Stacklet")
@@ -295,40 +295,38 @@ def login(ctx, username, password):
 
     If password is not passed in, your password will be prompted
     """
-    with StackletContext(ctx.obj["config"], ctx.obj["raw_config"]) as context:
-        # sso login
-        if context.can_sso_login() and not any([username, password]):
-            from stacklet.client.platform.vendored.auth import BrowserAuthenticator
-
-            BrowserAuthenticator(
-                authority_url=context.config.auth_url,
-                client_id=context.config.cognito_client_id,
-                idp_id=context.config.idp_id,
-            )()
-            return
-        elif not context.can_sso_login() and not any([username, password]):
-            click.echo(
-                "To login with SSO ensure that your configuration includes "
-                + "auth_url, and cognito_client_id values."
-            )
-            raise Exception()
-
-        # handle login with username/password
-        if not username:
-            username = click.prompt("Username")
-        if not password:
-            password = click.prompt("Password", hide_input=True)
-        manager = CognitoUserManager.from_context(context)
-        res = manager.login(
-            user=username,
-            password=password,
+    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
+    # sso login
+    if context.can_sso_login() and not any([username, password]):
+        from stacklet.client.platform.vendored.auth import BrowserAuthenticator
+
+        BrowserAuthenticator(
+            authority_url=context.config.auth_url,
+            client_id=context.config.cognito_client_id,
+            idp_id=context.config.idp_id,
+        )()
+        return
+    elif not context.can_sso_login() and not any([username, password]):
+        click.echo(
+            "To login with SSO ensure that your configuration includes "
+            + "auth_url, and cognito_client_id values."
         )
-        if not os.path.exists(
-            os.path.dirname(os.path.expanduser(StackletContext.DEFAULT_CREDENTIALS))
-        ):
-            os.makedirs(os.path.dirname(os.path.expanduser(StackletContext.DEFAULT_CREDENTIALS)))
-        with open(os.path.expanduser(StackletContext.DEFAULT_CREDENTIALS), "w+") as f:  # noqa
-            f.write(res)
+        raise Exception()
+
+    # handle login with username/password
+    if not username:
+        username = click.prompt("Username")
+    if not password:
+        password = click.prompt("Password", hide_input=True)
+    manager = CognitoUserManager.from_context(context)
+    res = manager.login(
+        user=username,
+        password=password,
+    )
+    if not os.path.exists(os.path.dirname(os.path.expanduser(StackletContext.DEFAULT_CREDENTIALS))):
+        os.makedirs(os.path.dirname(os.path.expanduser(StackletContext.DEFAULT_CREDENTIALS)))
+    with open(os.path.expanduser(StackletContext.DEFAULT_CREDENTIALS), "w+") as f:  # noqa
+        f.write(res)
 
 
 for c in commands:

stacklet/client/platform/commands/cube.py

@@ -60,31 +60,31 @@ def resource_counts(ctx):
 
 
 def _run_query(ctx, query):
-    with StackletContext(ctx.obj["config"], ctx.obj["raw_config"]) as context:
-        token = get_token()
+    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
+    token = get_token()
 
-        url = f"https://{context.config.cubejs}/cubejs-api/v1/load"
+    url = f"https://{context.config.cubejs}/cubejs-api/v1/load"
 
-        data = {"query": query}
-        response = requests.post(
-            url=url,
-            headers={"Authorization": token, "Content-Type": "application/json"},
-            data=json.dumps(data),
-        )
-        return response.json()
+    data = {"query": query}
+    response = requests.post(
+        url=url,
+        headers={"Authorization": token, "Content-Type": "application/json"},
+        data=json.dumps(data),
+    )
+    return response.json()
 
 
 def _get(ctx, path: str):
-    with StackletContext(ctx.obj["config"], ctx.obj["raw_config"]) as context:
-        token = get_token()
+    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
+    token = get_token()
 
-        url = f"https://{context.config.cubejs}/cubejs-api/{path}"
+    url = f"https://{context.config.cubejs}/cubejs-api/{path}"
 
-        response = requests.get(
-            url=url,
-            headers={"Authorization": token, "Content-Type": "application/json"},
-        )
-        return response.json()
+    response = requests.get(
+        url=url,
+        headers={"Authorization": token, "Content-Type": "application/json"},
+    )
+    return response.json()
 
 
 _resource_counts = {

stacklet/client/platform/commands/user.py

@@ -29,15 +29,15 @@ def add(ctx, username, password, email=None, phone_number=None, permanent=True):
     """
     Add a cognito user in Stacklet
     """
-    with StackletContext(ctx.obj["config"], ctx.obj["raw_config"]) as context:
-        manager = CognitoUserManager.from_context(context)
-        manager.create_user(
-            user=username,
-            password=password,
-            email=email,
-            phone_number=phone_number,
-            permanent=permanent,
-        )
+    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
+    manager = CognitoUserManager.from_context(context)
+    manager.create_user(
+        user=username,
+        password=password,
+        email=email,
+        phone_number=phone_number,
+        permanent=permanent,
+    )
 
 
 @user.command("ensure-group")
@@ -48,10 +48,10 @@ def ensure_group(ctx, username, group):
     """
     Ensure that the specified user has the group if the group is available.
     """
-    with StackletContext(ctx.obj["config"], ctx.obj["raw_config"]) as context:
-        manager = CognitoUserManager.from_context(context)
-        success = manager.ensure_group(
-            user=username,
-            group=group,
-        )
-        ctx.exit(0 if success else 1)
+    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
+    manager = CognitoUserManager.from_context(context)
+    success = manager.ensure_group(
+        user=username,
+        group=group,
+    )
+    ctx.exit(0 if success else 1)

stacklet/client/platform/context.py

@@ -24,12 +24,6 @@ def __init__(self, config=None, raw_config=None):
         else:
             self.config = StackletConfig.from_file(self.DEFAULT_CONFIG)
 
-    def __enter__(self):
-        return self
-
-    def __exit__(self, type, value, traceback):
-        return
-
     def can_sso_login(self):
         return all(
             [

stacklet/client/platform/executor.py

@@ -59,28 +59,28 @@ def wrapper(func):
 
 
 def _run_graphql(ctx, name=None, variables=None, snippet=None, raw=False):
-    with StackletContext(ctx.obj["config"], ctx.obj["raw_config"]) as context:
-        token = get_token()
-        executor = StackletGraphqlExecutor(context, token)
-
-        if variables is None:
-            variables = {}
-
-        registry_snippet = StackletGraphqlExecutor.registry.get(name)
-
-        for k, v in variables.items():
-            transformer = registry_snippet.variable_transformers.get(k)
-            if not transformer:
-                continue
-            variables[k] = transformer(v)
-
-        if name and registry_snippet:
-            snippet = registry_snippet
-        elif name and registry_snippet is None:
-            raise Exception("No snippet found, got name:%s snippet:%s" % (name, registry_snippet))
-
-        res = executor.run(snippet=snippet, variables=variables)
-        if raw:
-            return res
-        fmt = Formatter.registry.get(ctx.obj["output"])()
-        return fmt(res)
+    context = StackletContext(ctx.obj["config"], ctx.obj["raw_config"])
+    token = get_token()
+    executor = StackletGraphqlExecutor(context, token)
+
+    if variables is None:
+        variables = {}
+
+    registry_snippet = StackletGraphqlExecutor.registry.get(name)
+
+    for k, v in variables.items():
+        transformer = registry_snippet.variable_transformers.get(k)
+        if not transformer:
+            continue
+        variables[k] = transformer(v)
+
+    if name and registry_snippet:
+        snippet = registry_snippet
+    elif name and registry_snippet is None:
+        raise Exception("No snippet found, got name:%s snippet:%s" % (name, registry_snippet))
+
+    res = executor.run(snippet=snippet, variables=variables)
+    if raw:
+        return res
+    fmt = Formatter.registry.get(ctx.obj["output"])()
+    return fmt(res)

tests/test_cognito.py

@@ -56,28 +56,28 @@ def test_cognito_user_manager_create_user(self):
         users = self.client.list_users(UserPoolId=self.cognito_user_pool_id)
         assert len(users["Users"]) == 0
 
-        with StackletContext(raw_config=config) as context:
-            manager = CognitoUserManager.from_context(context)
-            manager.create_user(
-                user="test-user",
-                password="Foobar123!",
-                email="foo@acme.org",
-                phone_number="+15551234567",
-            )
-            users = self.client.list_users(UserPoolId=self.cognito_user_pool_id)
-            assert users["Users"][0]["Username"] == "test-user"
-
-            # creating a user is an idempotent action, this should return true without
-            # raising an error
-            res = manager.create_user(
-                user="test-user",
-                password="Foobar123!",
-                email="foo@acme.org",
-                phone_number="+15551234567",
-            )
-            assert res is True
-            users = self.client.list_users(UserPoolId=self.cognito_user_pool_id)
-            assert users["Users"][0]["Username"] == "test-user"
+        context = StackletContext(raw_config=config)
+        manager = CognitoUserManager.from_context(context)
+        manager.create_user(
+            user="test-user",
+            password="Foobar123!",
+            email="foo@acme.org",
+            phone_number="+15551234567",
+        )
+        users = self.client.list_users(UserPoolId=self.cognito_user_pool_id)
+        assert users["Users"][0]["Username"] == "test-user"
+
+        # creating a user is an idempotent action, this should return true without
+        # raising an error
+        res = manager.create_user(
+            user="test-user",
+            password="Foobar123!",
+            email="foo@acme.org",
+            phone_number="+15551234567",
+        )
+        assert res is True
+        users = self.client.list_users(UserPoolId=self.cognito_user_pool_id)
+        assert users["Users"][0]["Username"] == "test-user"
 
     def default_args(self) -> list[str]:
         return [