Skip to content

hook: no committed behavioral launcher smoke (deno-in-CI test gap, P2) #90

Description

@systemfsoftware-maker

Source: ce-code-review run 20260830-212446-4b8b0529 (testing + adversarial testing_gaps).

What

The launcher's core fix (catch-all spawn-failure collapse), the direnv fallback, exit-code pass-through, and stdin payload plumbing have no committed test: wire.rs is text-grep only, and the plan's verification smokes were session-scoped. A regression to throw passes CI.

Fix options

  • wire.rs: assert } catch { present and throw error absent (done: mechanism pair, not comment token).
  • Stronger: commit a behavioral smoke in CI (stub comment-checker/direnv on a temp PATH, LD_FOR_BUILD set, pipe a flagged Write payload, assert exit 2 + report on stderr). Needs deno on the CI runner for the plugin surface.

Carried by PR #92: #92

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions