Skip to content

Move classes to Devmail "namespace"? #6

Description

@oneiros

First of all thanks for devmail. It has been immensely helpful in getting specs up and running for https://github.com/oneiros/carbon_smtp_adapter/

Since I use it in a way it might not have been intended for (as a library rather than a stand-alone tool), I am a bit concerned about how devmail "pollutes" the global namespace.

Best practice in crystal (quite similar to ruby) is to wrap all classes in src/devmail in a Devmail module/namespace.

Would you accept a PR moving all classes into such a namespace?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions