From 05a8f58c2d4a5922da013d90795dbd3fb5708f99 Mon Sep 17 00:00:00 2001 From: Junjun Zhang Date: Sun, 18 Oct 2026 15:12:35 +0800 Subject: [PATCH] fix(tui): stop rendering memory consolidation findings as startup notices Sleep-time consolidation findings (stale/repair suggestions) were appended to startupNotices and rendered as first-frame system messages in the TUI. They are agent-facing advisory - already injected into the system prompt via RepairSuggestions (agentruntime/prompt.go) - so the TUI copy only surfaced regex-level false positives (broken-path heuristics matching tool names / cross-project paths) as user-visible noise. Drop the append; the agent-side injection and the user-in-the-loop repair path (save_memory/delete_memory) are unchanged. MCP gate/merge startup notices still render as before. Verified: go build green, full go test ./cmd/ggcode/ ok (22.2s), root_test.go has no assertions on the removed behavior. Co-Authored-By: ggcode Co-Authored-By: ggcode --- cmd/ggcode/root.go | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/cmd/ggcode/root.go b/cmd/ggcode/root.go index 4dbf7216f..b3b2d7f9c 100644 --- a/cmd/ggcode/root.go +++ b/cmd/ggcode/root.go @@ -525,10 +525,15 @@ func run(cfg *config.Config, cfgFile, resumeID string, bypass bool) error { projectAutoMem := core.ProjectAutoMem saveMemoryTool := core.SaveMemoryTool startupAssets := core.StartupAssets - // Startup notices (sa-45): merge MCP gate/merge warnings with - // sleep-time consolidation findings and hand the combined list to the - // TUI so they render as system messages on the first frame. - startupNotices := append(core.StartupNotices, startupAssets.ConsolidationFindings...) + // Startup notices (sa-45): MCP gate/merge warnings render as system + // messages on the first frame. Sleep-time consolidation findings are + // deliberately NOT appended anymore: they are agent-facing advisory + // (already injected into the system prompt via RepairSuggestions, + // agentruntime/prompt.go) - showing them in the TUI only surfaced + // regex-level false positives (broken-path heuristics on tool names / + // cross-project paths) as user-visible noise. User stays in the loop + // when the agent acts on a suggestion (save_memory/delete_memory). + startupNotices := core.StartupNotices autoFiles := startupAssets.AutoFiles commandMgr := startupAssets.CommandManager trace.Mark("build interactive runtime core")