From fc90e12e51848bfe75b0b3af853cf5a61364855d Mon Sep 17 00:00:00 2001 From: Junjun Zhang Date: Thu, 22 Oct 2026 09:40:16 +0800 Subject: [PATCH] chore: remove confirmed dead code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit deadcode r82: remove ClientManager.SetPermissionHandler/SetApprovalHandler (internal/acp/client_manager.go) — dual-mode (deadcode + deadcode -test -tags goolm) intersection entries with zero repo-wide references; fields onPermission/onApproval remain consumed by Get(), no logic change. Delta verified: intersection 197→195, no newly-dead entries; build/vet RC=0. AgentLoop fs-delegation face yielded to #4337 (r78 branch). Co-Authored-By: ggcode --- internal/acp/client_manager.go | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/internal/acp/client_manager.go b/internal/acp/client_manager.go index e22d430ab..982cd7a04 100644 --- a/internal/acp/client_manager.go +++ b/internal/acp/client_manager.go @@ -50,24 +50,6 @@ func (m *ClientManager) SetWorkingDir(dir string) { } } -func (m *ClientManager) SetPermissionHandler(h PermissionHandler) { - m.mu.Lock() - defer m.mu.Unlock() - m.onPermission = h - for _, client := range m.clients { - client.SetPermissionHandler(h) - } -} - -func (m *ClientManager) SetApprovalHandler(h ApprovalHandler) { - m.mu.Lock() - defer m.mu.Unlock() - m.onApproval = h - for _, client := range m.clients { - client.SetApprovalHandler(h) - } -} - // Available returns the list of available agent names. func (m *ClientManager) Available() []string { m.mu.RLock()