From d9f9d4efb32f1b81c96d7a1f416960976cf7fef6 Mon Sep 17 00:00:00 2001 From: Tiyatrotist <179411334+Tiyatrotist@users.noreply.github.com> Date: Tue, 6 Oct 2026 19:10:45 +0300 Subject: [PATCH] docs(codeowners): add profiler co-owners for assets/profiler-heldout.js --- .github/CODEOWNERS | 1 + tests/test_codeowners.py | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 8c08b50a..11fce43c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -61,6 +61,7 @@ /assets/ @yakew7 /assets/profiler-engine.js @yakew7 @ahmdkaml /assets/profiler-compare.js @yakew7 @ahmdkaml +/assets/profiler-heldout.js @yakew7 @ahmdkaml /assets/profiler-ui.js @yakew7 @ahmdkaml /assets/profiler.css @yakew7 @ahmdkaml /profiler.html @yakew7 @ahmdkaml diff --git a/tests/test_codeowners.py b/tests/test_codeowners.py index 9fe9bed4..e63d6124 100644 --- a/tests/test_codeowners.py +++ b/tests/test_codeowners.py @@ -153,3 +153,21 @@ def test_every_codeowners_owner_is_a_valid_github_handle(): if not handle_re.match(owner) ] assert not bad, "\n".join(bad) + + +def test_profiler_scripts_are_co_owned(): + entries = _parse_codeowners_paths() + owner_map = {pattern: owners for _line_no, pattern, owners in entries} + for script in [ + "/assets/profiler-engine.js", + "/assets/profiler-compare.js", + "/assets/profiler-heldout.js", + "/assets/profiler-ui.js", + "/assets/profiler.css", + "/profiler.html", + ]: + assert script in owner_map, f"{script} missing from CODEOWNERS" + assert "@yakew7" in owner_map[script] and "@ahmdkaml" in owner_map[script], ( + f"{script} is not co-owned by @yakew7 and @ahmdkaml" + ) +