From 890e768d62063c690dd6ca6e60a94f1a4834007d Mon Sep 17 00:00:00 2001
From: Ghattamaneni Venkateswararao <venkateswara.rao@zaggle.in>
Date: Sat, 10 Oct 2026 07:47:48 +0530
Subject: [PATCH] Fix Console tab crash after a screen size change

console_scroll_view was a FrameLayout in the phone console layout and a
ScrollView in the large layout. State saved under that id on a phone
size was restored into the ScrollView after the screen became large
(fold open, window resize), so opening the Console tab threw
ClassCastException in ScrollView.onRestoreInstanceState.

Drop the unused id from the phone FrameLayout.
---
 app/src/main/res/layout/fragment_console_tab.xml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/src/main/res/layout/fragment_console_tab.xml b/app/src/main/res/layout/fragment_console_tab.xml
index 91e7cb3..1cbd647 100644
--- a/app/src/main/res/layout/fragment_console_tab.xml
+++ b/app/src/main/res/layout/fragment_console_tab.xml
@@ -6,11 +6,12 @@
         <variable name="machineStatus" type="in.co.gorest.grblcontroller.listeners.MachineStatusListener" />
     </data>
 
-    <!-- Not a ScrollView: the page must stay screen high so the console well takes the spare space. -->
+    <!-- Not a ScrollView: the page must stay screen high so the console well takes the spare space.
+         No id: the large layout uses console_scroll_view on a ScrollView, and the same id on a
+         different view type crashes the view state restore when the screen size changes. -->
     <FrameLayout
         android:paddingStart="@dimen/screen_edge"
         android:paddingEnd="@dimen/screen_edge"
-        android:id="@+id/console_scroll_view"
         android:paddingTop="@dimen/spacing_s"
         android:layout_width="match_parent"
         android:layout_height="match_parent">