chore: bump miden-protocol dependencies to 0.17.0-rc.4 - #2617
Merged
Merged
Conversation
Mirko-von-Leipzig
approved these changes
Sep 12, 2026
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
Collaborator
There was a problem hiding this comment.
As mentioned in one of the comments, we should be using the actual miden-protobuf traits to replace all of our own TryFrom implementations.
Its unclear how much extra work that entails, so I'm okay with merging this as an intermediate form to unblock the client.
Co-authored-by: Mirko <48352201+Mirko-von-Leipzig@users.noreply.github.com>
Mirko-von-Leipzig
added this pull request to stack #2622
September 14, 2026 13:26
…ocol-0.17.0-rc.4 # Conflicts: # bin/benchmark/src/create_proofs.rs # bin/benchmark/src/rpc_state.rs # bin/large-account-benchmark/src/rpc.rs # bin/network-monitor/src/deploy/mod.rs # bin/node/src/commands/recover.rs # crates/block-producer/src/rpc_sync.rs
sofiazcoaga
marked this pull request as ready for review
September 14, 2026 14:15
…ocol-0.17.0-rc.4 # Conflicts: # crates/proto/src/domain/proof_request.rs # crates/rpc/src/tests.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade to
miden-protocol0.17.0-rc.4. Needed to integrate the same version in the client.Main changes:
miden-protocolcrates from0.17.0-rc.3to0.17.0-rc.4.TryFrom<proto>conversion withdecode_fields()plus an explicitverify(),verify_with(context)orbuild_unchecked().verify_field,verify_value,verify_optionaland theverify!macro.Changelog