Collect batch fees into a single P2ID note - #2647
Open
Mirko-von-Leipzig wants to merge 4 commits into
Open
Mirko-von-Leipzig wants to merge 4 commits into
Mirko-von-Leipzig wants to merge 4 commits into
Conversation
Mirko-von-Leipzig
added this pull request to stack #2641
September 18, 2026 07:31
Mirko-von-Leipzig
removed this pull request from stack #2641
September 18, 2026 09:45
Mirko-von-Leipzig
force-pushed
the
mirko/collect-batch-fees
branch
from
September 18, 2026 09:47
c2c602d to
07dcbd1
Compare
Mirko-von-Leipzig
added this pull request to stack #2649
September 18, 2026 09:47
Mirko-von-Leipzig
force-pushed
the
mirko/collect-batch-fees
branch
from
September 18, 2026 10:12
07dcbd1 to
4f66375
Compare
Mirko-von-Leipzig
marked this pull request as ready for review
September 18, 2026 10:19
Mirko-von-Leipzig
force-pushed
the
mirko/collect-batch-fees
branch
from
September 18, 2026 10:37
4f66375 to
b8cf51d
Compare
PhilippGackstatter
approved these changes
Sep 18, 2026
PhilippGackstatter
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me ito fee collector usage.
Mirko-von-Leipzig
force-pushed
the
mirko/collect-batch-fees
branch
from
September 18, 2026 12:13
b8cf51d to
d1aa8e5
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/collect-batch-fees
branch
from
September 18, 2026 12:24
d1aa8e5 to
076ab6e
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/collect-batch-fees
branch
from
September 18, 2026 12:48
6c853a1 to
5d8a1a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The batch builder uses the
fee-collectoraccount to send tx fees to a configured wallet. The collection of this by the wallet is left to a separate service or app, and is not critical for now.The sequencer CLI accepts
--batch.builder.wallet-account-idas the recipient of batch-building fees. The wallet is managed separately; the sequencer does not need its account file or signing key. Local development networks and benchmarks send collected fees to an arbitrary non-existent account ID for now.The
fee-collectoris now required by the sequencer in order to startup, as otherwise batch building won't work.Batch selection reserves capacity for the collector transaction and its output note. The mempool distinguishes the selected batch ID from the proven batch ID because the appended transaction changes the ID. Batches without fee notes omit the collector transaction and keep their selected batch ID.
The batch builder submits the appended collector transaction to the validators before proving the batch.
Part of #2501.
Changelog