Pass the FDS BIOS through HotSwap so disk images can be hot swapped - #1
Open
UndocumentedWorlds wants to merge 1 commit into
Open
UndocumentedWorlds wants to merge 1 commit into
UndocumentedWorlds wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HotSwap()callsInit(null, rom, null). On the FDS code path,Init()throws before the board is created:
So hot swapping to any
.fdsimage fails immediately, regardless offirmware configuration. Cartridge swaps are unaffected because
Init()never reads the third argument on the iNES/UNIF path.
Change
The constructor already resolves the BIOS. This keeps that array and
passes it through on swap.
Using the stored array rather than re-fetching it matters: the
constructor applies the 40976-byte bad-dump correction, and re-fetching
would skip it.
Notes
hotSwappingflag still does that work.
Init(), so the 32 KB PRG-RAM is notcarried across. It is reloaded from the new disk anyway.
Init(), so both headered.fdsfiles and raw disk images (\x01*NI) are handled. Passing thearray unconditionally would behave the same; the check is there to
keep the intent readable.
Testing
$0000-$07FFispreserved across the swap.
Check if completed: