Skip to content

ci(gate): add path-aware quality checks - #66

Closed
huyanxius wants to merge 2 commits into
mainfrom
ci/preview-quality-gate
Closed

huyanxius wants to merge 2 commits into
mainfrom
ci/preview-quality-gate

Conversation

@huyanxius

Copy link
Copy Markdown
Collaborator

Change Description

  • Add one always-reported Quality gate check on the default branch.
  • Run frontend validation only for frontend/** changes and backend validation only for backend/** changes.
  • Move Vercel build routing to the repository root so backend-only branches are skipped before frontend commands run.

Implementation Approach

  • Detect changed areas once, run the relevant jobs, and aggregate success or skipped results into one branch-protection-friendly check.
  • Keep GitHub Actions read-only for fork pull requests.
  • Use a root vercel.json with explicit frontend commands and an ignore command that also handles branches without a frontend directory.

Testing

  • Frontend: npm run format:check, npm run lint, npm run typecheck, npm run test (19 files, 81 tests), npm run build — passed on PR feat(frontend): add MS2 skeleton with module contracts #59 head.
  • Backend: uv sync --frozen, uv run ruff check ., uv run lint-imports, uv run pytest -q — passed on PR feat:module api skeletons #64 head.
  • Workflow YAML parse, JSON parse, shell syntax, git diff --check, and frontend/backend path detection — passed locally.

Risks

  • Vercel project Root Directory must be changed from frontend to the repository root after this PR is merged.
  • Git Fork Protection should only be disabled after confirming Preview has no secrets or trusted OIDC permissions.

Pull requests currently lack a trusted check on the default branch.

Route frontend and backend changes to their existing validation commands.

Always publish one quality-gate result that branch protection can require.
The Vercel project currently treats every repository update as a frontend deployment.

Build from repository root and skip branches that do not contain frontend changes.

Backend-only pull requests no longer fail before the ignore decision can run.
@vercel

vercel Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
windup Ignored Ignored Preview Jul 30, 2026 2:43am

@huyanxius huyanxius closed this Jul 30, 2026
@huyanxius
huyanxius deleted the ci/preview-quality-gate branch July 30, 2026 03:59

This branch had an error being deployed

1 failed deployment
Preview — 0711999c Deployed Jul 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant