Repository navigation
Update libomp build to LLVM 23.1.2 - #113
Conversation
LLVM 23 removed the legacy standalone openmp build, so build it via the runtimes directory with -DLLVM_ENABLE_RUNTIMES=openmp. Also avoid failing on unset MACOSX_DEPLOYMENT_TARGET under set -u. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe build script now defaults to LLVM 23.1.2 and configures OpenMP through LLVM’s runtimes directory. It prints an empty deployment-target value when ChangesOpenMP build configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The OpenMP build has no verified configuration blocker. macOS wheels target 10.15, with no lower minimum declared by the project. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
libomp from LLVM 23 uses aligned_alloc, which requires macOS 10.15. cibuildwheel defaults before-all to MACOSX_DEPLOYMENT_TARGET=10.9. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LLVM 23 removed the legacy standalone openmp build, so build it via the runtimes directory with -DLLVM_ENABLE_RUNTIMES=openmp. Also avoid failing on unset MACOSX_DEPLOYMENT_TARGET under set -u.
Summary by CodeRabbit