Repository navigation
Document the comparator contract of find, find_all and find_next_in_subtree - #70
Merged
Merged
Conversation
- Comparator tests keep to the contract that compare never accepts a high below ival.high(). - Exact-match tests check that those overloads find everything and prune by max.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparator overloads skip subtrees whose max is below ival.high(), so a compare function that accepts an interval with a smaller high misses matches. That is now stated as a contract in the README and the doc comments: compare must never return true for an interval whose high is below ival.high().
For float comparisons, the README now says to lower the high of ival by the tolerance.
Adds tests for the comparator overloads within that contract, a float tolerance search, and the exact-match overloads (including that they still prune by max).