Repository navigation
bug: a clip's preload and its real play share one edge cache copy - #641
Merged
Merged
Conversation
…d keeps one edge copy of a clip whether or not its request is marked noview
…r's warm-up stays noview and shares the play's edge copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web now preloads the next clip with
?noview=1so the preload isn't counted as a view; the Worker's edge cache key was the full request URL, so that preload warmed a separate copy from B2.noviewis stripped from the edge cache key (only the raw query is edited, so existing entries keep their keys)noviewrequests still aren't counted, everything else is