Repository navigation
fix: a panel on external S3 leaves the built-in RustFS out of its overlays - #715
Merged
Merged
Conversation
…rlays write_overlays reads S3_ENDPOINT from overlays/config/s3-config.env, like TURN_DOMAIN. Anything but empty, rustfs or minio (with or without a scheme or port) adds the external-s3 component, which drops the RustFS StatefulSet, its Services, console route, volume, secrets and the demos route's bucket rule. Nothing already running is deleted, and update.sh only hands a MinIO volume to RustFS on built-in storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A panel whose
S3_ENDPOINTpoints at external storage no longer renders the built-in RustFS, so an update doesn't start a StatefulSet it never uses.write_overlaysreadsS3_ENDPOINTstraight fromoverlays/config/s3-config.env, likeTURN_DOMAIN, soupdate.shand the 5Stack service decide the same way. Empty,rustfsorminio(any case, with or without a scheme or port) is built in.overlays/external-s3component. It drops the RustFS StatefulSet, therustfsandminioServices, the console route,minio-pv/minio-pvc,rustfs-secrets(Secret or ExternalSecret), and the demos route's/5stackrule.update.shonly hands a MinIO volume to RustFS on built-in storage.write_overlays_test.shcovers the endpoint rule and renders every overlay both ways. The new tests fail on main.