Repository navigation
fix: practice saves that could not reach the panel now retry on their own - #289
Merged
Merged
Conversation
… a new map with an old workshop id A panel row's client id is its panel id while a session save keeps its guid, so after a push the delete missed the row in the walk, library and drill, and the walk label lost its place. They now match on client id or panel id, with the id read before ForgetSaves gives it up. The session fetch reads Map then WorkshopId off the game thread, so WorkshopId is now set first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A practice save that could not reach the panel told the player it would retry, and nothing retried it until a later save happened to get through.
.deletenow names the player, so it works, finds a row a push swapped in, withdraws held saves and moves a running drill on.https://github.com/DEAFCS/game-server/commit/baf0911b