Skip to content

fix: practice saves that could not reach the panel now retry on their own - #289

Merged
lukepolo merged 2 commits into
mainfrom
bug/deafcs-practice-save-retry
Nov 3, 2026
Merged

lukepolo merged 2 commits into
mainfrom
bug/deafcs-practice-save-retry

Conversation

@lukepolo

@lukepolo lukepolo commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

A practice save that could not reach the panel told the player it would retry, and nothing retried it until a later save happened to get through.

  • Held saves and results are tried again every 10 seconds, with an attempt cap, and a retry keeps its id so it can't make a second lineup or count a throw twice.
  • A refused save leaves the queue and tells the player, instead of blocking everything behind it.
  • A retried save gets its panel id back and returns to the library if a refresh dropped it.
  • .delete now names the player, so it works, finds a row a push swapped in, withdraws held saves and moves a running drill on.
  • A save names its map and workshop id, the session reports the workshop id, and a save never sent stays here if the map moved.
  • A panel push updates a walk in place and removes deleted lineups from a drill, instead of resetting the walk.

https://github.com/DEAFCS/game-server/commit/baf0911b

… a new map with an old workshop id

A panel row's client id is its panel id while a session save keeps its guid, so
after a push the delete missed the row in the walk, library and drill, and the
walk label lost its place. They now match on client id or panel id, with the id
read before ForgetSaves gives it up.

The session fetch reads Map then WorkshopId off the game thread, so WorkshopId
is now set first.
@lukepolo
lukepolo merged commit 72fdd0d into main Nov 3, 2026
7 of 8 checks passed
@lukepolo
lukepolo deleted the bug/deafcs-practice-save-retry branch November 3, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant