Skip to content

refactor: remove obsolete TUI and runtime scaffolding - #260

Merged
wangtsiao merged 2 commits into
7df-lab:mainfrom
wangtsiao:chore/remove-obsolete-scaffolding
Nov 6, 2026
Merged

wangtsiao merged 2 commits into
7df-lab:mainfrom
wangtsiao:chore/remove-obsolete-scaffolding

Conversation

@wangtsiao

@wangtsiao wangtsiao commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove seven unreachable vendored TUI modules: resource-loader, side-question, agent-observe, output-guard, daemon-socket, daemon-worker-protocol, and daemon-client-env.
  • Remove the unused private CLI launch wrapper, internal FragmentRegistration/FragmentRegistrationProxy scaffolding, and the two unused session registry helpers.
  • Replace the always-Some legacy session lookup with direct Native IDs, keeping the active-stream fallback and persistence behavior.
  • Remove the duplicate DEVO_CODING_AGENT_DIR assignment guard. Add isolated environment/idempotence tests and Native item-sequence fallback regressions.

Scope checks

  • Checked tracked imports, exports, symbol consumers, dynamic imports, package entry points, and runtime packaging before deleting the TUI files. No consumers or exclusive tests remain.
  • Keep public context traits, shared dependencies, the live interactive side-question component, daemon socket-path utility, and non-blocking session handle methods.
  • Based on current upstream main f85d331. The patch merges cleanly with refactor: use live models.dev and pinned user connections #259 at c48823a; its only overlapping file is host.ts, in a separate hunk.

Validation

  • TUI suite: 252 passed, 0 failed, 3 skipped because local server binaries are not built.
  • Additional CI TUI tests: 7 passed.
  • Runtime packaging tests: 2 passed. Built the actual Linux x64 TUI bundle and imported its packaged host successfully.
  • TypeScript: 284 existing diagnostics, byte-for-byte identical after path normalization to an untouched main checkout with identical dependencies.
  • Core context tests: 21 passed, 1 ignored benchmark.
  • Server item unit tests: 3 passed, including both new fallback regressions.
  • Persistence integration tests: 26 passed in persistence_resume and 4 passed in turn_start_persistence.
  • Rust formatting and git diff whitespace checks passed.
  • Local CLI/core/server all-targets check passed.
  • CI on final head 183f279: Check, Clippy, Windows Rust checks, Rustfmt, Doc, both TUI jobs, tmux smoke, desktop tests/types, and all kernel targets passed.
  • Full workspace tests, all runtime bundle targets, and the CLI build benchmark passed on head 183f279. All three workflows completed successfully.

@wangtsiao
wangtsiao marked this pull request as ready for review November 6, 2026 08:24
@wangtsiao
wangtsiao merged commit b02804c into 7df-lab:main Nov 6, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant