Skip to content

fix(desktop): scope keyboard actions and restore title focus - #267

Draft
wangtsiao wants to merge 1 commit into
7df-lab:mainfrom
wangtsiao:fix/desktop-keyboard-interaction-20261108
Draft

wangtsiao wants to merge 1 commit into
7df-lab:mainfrom
wangtsiao:fix/desktop-keyboard-interaction-20261108

Conversation

@wangtsiao

@wangtsiao wangtsiao commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Scope question shortcuts to the focused question card, preserve focused button activation, and leave IME confirmation Enter untouched (including keyCode 229).
  • Keep card Escape ahead of root session navigation and scope question input focus to its own card.
  • Register session undo/redo only for the active transcript, preserve editor-native history, and accept uppercase Shift+Z.
  • Accept uppercase Shift+D/F in SessionShell and restore title editor focus/select.
  • Preserve existing visual styling and add 12 React-mounted interaction regressions.

Validation

  • Desktop tests with frozen-lockfile dependencies: 938 passed, 1 platform skip, 0 failed (bun test --isolate; writable XDG_CONFIG_HOME for the backup test).
  • tsc --noEmit: passed locally on the implementation, and passed again in exact-head CI. A later local rerun was resource-killed (exit 137).
  • Focused question/permission/root navigation/history/shell tests after the final focus change: 21 passed.
  • git diff --check: passed. New hook and test-file Biome lint: no errors (test non-null assertions produce warnings).
  • Full repository Biome check remains failing on existing formatting/lint findings; no repository-wide cleanup included.
  • Cargo is unavailable locally. Desktop protocol output was copied verbatim from the tracked TUI generated files at base commit 4228c9d; Exact-head CI has since passed with the canonical generator.

CI at c40f31a

  • CI #631: success, including Desktop tests and types. Unaffected Rust/TUI jobs were skipped by path selection.
  • Runtime bundles #152: success, all six target platforms.

No merge or deployment included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant