Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correctness/diagnostics slice of the MCP connection-experience work, based on main
4228c9d. This is not a claim that native OAuth login/refresh migration is complete.mcp.refresh/mcp.configsuccessful no-ops with actionable unsupported-contract errors. Native discovery refresh cannot rotate the authored integrations' separate auth.json grants.rlm.mcp.list_servers()over the existing session manager's observed states, without returning transport configuration or credentials. Require a ready state for discovery success.list_tools()rechecks the connection and clears stale schemas on failure. No fallback transport for native calls and no replay of failed writes.docs/mcp-connection-lifecycle.md.Verification
cargo fmt --all -- --checkandgit diff --check: passed.devo-server --lib: 553 passed, 3 failed, 3 ignored. The failures are unchanged non-Git workspace/worktree tests (plain_folders_have_no_worktrees_but_missing_folders_are_errors,non_git_finalized_turn_view_is_stable_after_later_changes,staged_and_unstaged_unsupported_without_head_and_outside_git). This container emits Git's mount-boundary error wording, which those paths do not classify asnot_git_repository; the isolated worktree test also fails. This is not a full-suite pass.d55f48bpreserves the existing behavior when another host reconnects while refresh fails: re-read and revalidate the persisted grant, without exposing the failed provider response. Two new regression cases and the real Rust→Python test pass locally.d55f48b80dd707c90c8754a388b40dc1f024c4d0: all 23 checks succeeded, including the full workspace Test job, Linux/Windows Check and Clippy, Desktop/TUI, Python 3.11/3.13 on Windows, native kernel builds, and all six runtime bundles. CI run: 42497452286. Runtime bundles run: 42497452295. This includes a passing remote full-suite result despite the three local environment-specific Git-detection failures described above.Review notes
The useful Prime pattern is that stored tokens are not equivalent to verified connection state. This change reuses Devo's existing manager states instead of copying a second catalog/transport system. It deliberately does not reroute authored credentials or calls to same-named user MCP servers.