Fix logical to physical axis mapping for attention heads. - #4607
Open
copybara-service[bot] wants to merge 1 commit into
Open
Fix logical to physical axis mapping for attention heads.#4607copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
NuojCheng,
RissyRan,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
huytransformer,
igorts-git,
jiangjy1982,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
xibinliu
as code owners
July 24, 2026 21:44
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
copybara-service
Bot
force-pushed
the
test_953561420
branch
from
July 24, 2026 22:35
e9c31c1 to
6352bce
Compare
niting
approved these changes
Jul 24, 2026
copybara-service
Bot
force-pushed
the
test_953561420
branch
6 times, most recently
from
July 27, 2026 22:15
d8ae19f to
9c229a2
Compare
PiperOrigin-RevId: 953561420
copybara-service
Bot
force-pushed
the
test_953561420
branch
from
July 27, 2026 23:21
9c229a2 to
9daa835
Compare
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'MaxText Test Execution Times'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.15.
| Benchmark suite | Current: 9daa835 | Previous: df95a1f | Ratio |
|---|---|---|---|
Total CPU-TORCH-REFERENCE Tests Duration |
288.14900000000006 sec |
226.67700000000002 sec |
1.27 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix logical to physical axis mapping for attention heads.
Description
Use self._logical_to_mesh_axes to pass logical rules to logical_to_mesh_axes, ensuring the logical axis (e.g. 'tensor') is correctly mapped to the physical mesh axis. This fixes crashes when running with logical sharding configs.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.