Refactor layer-wise tests with torch - #4633
Open
hengtaoguo wants to merge 1 commit into
Open
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hengtaoguo
force-pushed
the
hengtaoguo-test
branch
from
July 27, 2026 22:46
8b79f50 to
755906b
Compare
resolve dep error
hengtaoguo
force-pushed
the
hengtaoguo-test
branch
from
July 28, 2026 03:05
755906b to
3855d6e
Compare
hengtaoguo
marked this pull request as ready for review
July 28, 2026 03:06
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
hengtaoguo
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
suexu1025,
vipannalla and
xibinliu
as code owners
July 28, 2026 03:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts the standalone
cpu_torch_reference_testsworkflow and integratesgemma4_layers_test.pyinto the standardcpu-unittests. The test is configured to run only on scheduled CI runs.maxtext_cpu_torch_reference_testsworkflow.gemma4_layers_test.pyinpytest.ini, and marked it ascpu_onlyandscheduled_only.cpu-unitonly during scheduled runs.TODO: After this atomic PR, follow up with another PR refactoring
import torchfor other layer-wise tests, and add them to scheduled runs cleanly.Tests
Note: GitHub Actions Scan is failing due to a very recent Google-wise security rollout on 07-27-2026.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.