Repository navigation
Let update.check in the settings turn the Validate update check off (#67) - #74
Merged
Merged
Conversation
An organization that wanted the template update check off had to edit the checkForUpdates input in Validate.yaml, a system file the next update overwrites (#67). The settings survive updates, so the switch belongs there. The settings schema gains update.check (boolean, default true; the schema stays closed). The Validate action input checkForUpdates now defaults to '' and Validate.ps1 takes it as a tri-state string: 'true' or 'false' (case-insensitive, $true and $false from in-process callers too) wins, '' follows update.check, read leniently so a missing or unreadable settings file or a non-boolean value leaves the check on. When the setting turns it off the log says "Update check off (update.check is false)" and UpdateCheck stays $null. The template settings do not ship the key (absent means true); the engine CI already passes checkForUpdates 'false' explicitly. Tests: the action input default, Invoke-Entry defaulting to 'false' so no test downloads a template, four precedence cases on update-org copies and two schema fixtures. Docs: update-mechanics section 7, ARCHITECTURE 5.5 and section 8, the template README. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Review round 1 of #67. The Validate.ps1 help and update-mechanics section 7 say that omitting -CheckForUpdates follows update.check (pass 'false' to skip). An explicit value other than 'true' or 'false' still turns the check off, now with the log line "checkForUpdates '<value>' is not 'true' or 'false'; the update check is off" (no annotation, no exit-code effect). Tests cover the omitted parameter with and without update.check and the unrecognised value. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schemas/rulebook-settings.schema.json: newupdate.check(boolean, default true; the schema stays closed). The template settings do not ship it; absent means true.checkForUpdatesdefaults to''andValidate.ps1takes it as a tri-state string.'true'/'false'(case-insensitive) wins;''or an omitted parameter followsupdate.check, read leniently (missing or unreadable settings, or a non-boolean value, leave the check on). When the setting turns it off the log saysUpdate check off (update.check is false)andUpdateCheckstays$null; any other explicit value turns it off with the log linecheckForUpdates '<value>' is not 'true' or 'false'; the update check is off.checkForUpdatesinput ofValidate.yaml, a system file the update overwrites.validate-actionsteps already passcheckForUpdates: 'false'.'';Invoke-Entrydefaults to'false'so no test downloads a template (OmitCheckleaves the parameter unbound); precedence cases onupdate-orgcopies (absent runs, false skips with the log line, explicit true beats false, explicit false beats true, omitted parameter with and without the key, an unrecognised value); schema fixturesupdate-check-false(valid) andupdate-check-not-boolean(invalid).docs/reference/update-mechanics.mdsection 7,docs/ARCHITECTURE.md(Validate action inputs, step 5, settings section 8),template/README.md, theValidate.ps1help.Verification: Pester 1495 tests (1494 passed, 1 skipped: the Actions-only smoke test), PSScriptAnalyzer clean, Test-Rulebook V1 to V14 clean, Build-Template -WhatIf current.
Review: one Sonnet round at effort high, no must-fix; applied: default documented, omitted-parameter tests, log line for unrecognised values; not applied: the triple settings parse (follow-up with #58-style consolidation if it recurs).
Closes #67
🤖 Generated with Claude Code