Repository navigation
Docs: quarantine.md, new diagnostics and the Scan Diagnostics workflow - #5
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…egeneration, closed PR, push failures, schedule, scan-state example); scan in ghtokenworkflow.md and updating.md Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…observed, keeping a rule off, local regeneration, published levels, column values); token rows apply to the scan Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/quarantine.mdfor organization maintainers: what the daily Scan Diagnostics workflow does, choosing the quarantine policy (with the exact abort message), reading its one living pull request (titles, sections with live examples, record runs, why the branch is rebuilt and must not be pushed to), adopting a quarantined rule and housekeeping, changed default severities and pinning, the catalog fields and flags andcatalog/scan-state.json, running it by hand (includePrerelease, direct commit,commitOptions.createPullRequest,scan.scheduleand the absent-key rule, rescanning a channel), troubleshooting.docs/README.md: the plannednew-rules.mdrow becomes the writtenquarantine.mdrow.docs/ghtokenworkflow.mdanddocs/updating.md: one sentence each on the scan using the same secret and the same schedule mechanism.docs/reference/scan-mechanics.md.Merge order: ALCops/rulebook-engine#69 first; until it merges, the link to its docs/reference/scan-mechanics.md is a 404 and the base-moved message in section 8 does not exist on main.
Decisions
WP08 (ALCops/rulebook-engine#10): D45 (one living pull request, record runs) and D46 (seeded ids are known; unadvertised, deprecated and vanished ids are catalog flags).
Review
Sonnet code-review, effort high, three rounds. Round 1: 15 findings (adoption example edited a shipped base/ file, stale endpoints after a hand edit, a closed PR returning, push failure wording, housekeeping exception, overrides never release an entry, and wording), fixed in 256d806; one engine change followed (base-moved reported plain, ALCops/rulebook-engine@e37e8d6). Round 2: 3 must-change items (the live PR #2 claim, None in an own level, PowerShell 7.4) and 8 optional, all applied in 429946c. Round 3: approve.
Relates to ALCops/rulebook-engine#10
🤖 Generated with Claude Code