Repository navigation
fix(engine): resolve interrupted-gate trust through the runner identity - #46
Merged
Merged
Conversation
- Resume looked up the trust entry by the exec root, so in a worktree checkout every entry missed and the step parked as "no trust entry". - Use the runner's identity, as the gate runner does, so the entry's re_runnable flag decides the outcome. - Cover a worktree layout and rebind the declared-files fixture to the identity it was only passing against by accident.
erikreinert
marked this pull request as ready for review
November 1, 2026 22:47
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resuming a step whose gate was interrupted looked up the trust entry by the exec root. In a worktree checkout the exec root differs from the trust identity, so every lookup missed and the step parked as "no trust entry" instead of honoring the entry's re_runnable flag.
Changes
Testing
go test ./internal/engine/ -run 'TestInterruptedGate|TestResume' -count=1: passed.