Write only to heads that are owned - #117
Open
AaronStGeorge wants to merge 1 commit into
Open
AaronStGeorge wants to merge 1 commit into
AaronStGeorge wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix high hrx perplexity in llama 3.1 8b found in this report: https://github.com/ROCm/ggml-staging-automation/actions/runs/36025928972
Overview
Fix errant bound check in flash_attention_decode_split_f32_f16_wmma.loom. The reducer allowed one KV group to overwrite another’s output. Two corrected bounds checks eliminate this.
Testing
See perplexity report with this change: https://github.com/ROCm/ggml-staging-automation/actions/runs/36058751562 (link to branch pulling this change in)