Repository navigation
Conversation
…ect fallback description is stale
…delta; full real-GPU rerun)
A deferral is discovered while porting and is evidence about THIS port, so it lives with the notes and the plan it came out of and is reviewed with them, rather than in a trunk-global file only the trunk can write.
A full real-GPU revalidation at 7727fa3 -- 222/222 conv-SE cross-checks in fp32 and fp16, 130/130 attention, determinism bit-identical to the original baseline -- got recorded through `carry_forward` because `set-state completed` no-ops when the stored state is already `completed`. That is the bug #9 fixed and this branch has not merged it. The tag asserts no GPU ran for this sha, the opposite of the truth, and under-sells a stronger result. The validation stands.
# Conflicts: # README.md
…fied against the live PR head)
…a3 on TheRock 7.14.0a20260612
…151's re-review; restore head_sha b87423d
# Conflicts: # README.md
# Conflicts: # .claude/skills/cuda-to-rocm/references/validation.md
# Conflicts: # README.md
The lc0 lesson put the single construction-end sync before the evaluation buffers are allocated, which leaves their async memset racing the non-blocking compute streams -- the hole review found in August. Upstream lc0 #2454 syncs after the memset loop; cite it as the reference shape. Authored with Claude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the completed control-plane records for lc0, plus two
cuda-to-rocmlessons from its Windows investigation.fix_abandoned) andmoat-portnow points at upstream master (4975680, upstream's own tree).pr_readyreads that as nothing to offer, so no follow-up PR is pending.lc0-move-sync-below-memsetclosed as done by upstream #2454 (jeff's ruling);lc0-ck-fused-mhastays ruleddefer.Skill text (needs review, since it publishes to every agent):
fault-classes.md: an init-time kernel on the legacy null stream is not ordered against non-blocking streams. Fingerprint, why Windows loses the race, and fix at the boundary with one sync after the last null-stream operation (upstream #2454 is the reference shape).validation.md: check what a project's cross-backend checker actually compares, and whether the test input reaches the changed path (lc0's--backend=checknever compares moves-left).Part of the misplaced-branch sweep.
🤖 Generated with Claude Code