ci(lint): run lint checks without requiring maintainer approval (#1441) - #1442
Conversation
…IE-Org#1441) Fork PR workflows on pull_request need maintainer approval, and that approval is all-or-nothing per PR event, so the lint job (44s) could never run without also releasing the gated frontend/backend/build jobs. Move linting into its own pull_request_target workflow, which the repo already uses for label-merge-conflicts and linked-issue, so it runs unattended while the expensive jobs stay gated exactly as before. Hardened with permissions: {}, no secrets, an explicit PR-head checkout with persist-credentials: false, and npm ci --ignore-scripts, since pull_request_target executes PR-controlled input in base-repo context.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe pull request adds a dedicated lint workflow for pull requests targeting ChangesPull Request Linting
Estimated code review effort: 3 (Moderate) | ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/lint.yml:
- Around line 44-47: Update the “Install backend lint dependencies” workflow
step to install pre-commit, ruff, and black from a reviewed backend lint
requirements file containing exact versions, rather than unpinned package names.
Ensure the workflow still changes into the backend directory and uses that file
for installation.
- Line 16: Update the lint workflow’s runtime configuration to use an active
Node.js LTS version supported by the frontend project instead of Node 18, while
preserving the existing current action pins for actions/checkout,
actions/setup-node, and actions/setup-python; only change checkout to v6 if the
workflow already targets that major version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 532f75dc-6f85-4b1e-a68f-8e2e1bea77a8
📒 Files selected for processing (2)
.github/workflows/lint.yml.github/workflows/pr-check-tests.yml
💤 Files with no reviewable changes (1)
- .github/workflows/pr-check-tests.yml
|
High value change. Let's address all the coderabbit reviews and get this merged quickly @VanshajPoonia |
Link your account with GitcordThanks for opening this PR, @VanshajPoonia! To receive Discord notifications and contributor tracking for this organization:
Once linked, Gitcord can notify you about reviews, merges, and more. — Posted by Gitcord |
CodeRabbit flagged two issues on AOSSIE-Org#1441: Node 18 is EOL, and pre-commit/ ruff/black were installed unpinned so runs could pick up different versions over time. Switch node-version to lts/*, matching pr-check-build.yml and release-prep.yml. Pin pre-commit/ruff/black in a new backend/requirements-lint.txt, with ruff and black matching the exact revs already in .pre-commit-config.yaml so the installed tools and the hooks pre-commit actually runs stay in sync.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@rohan-pandeyy Please review |
2 participants
Fork PR workflows on pull_request need maintainer approval, and that approval is all-or-nothing per PR event, so the lint job (44s) could never run without also releasing the gated frontend/backend/build jobs.
Move linting into its own pull_request_target workflow, which the repo already uses for label-merge-conflicts and linked-issue, so it runs unattended while the expensive jobs stay gated exactly as before. Hardened with permissions: {}, no secrets, an explicit PR-head checkout with persist-credentials: false, and npm ci --ignore-scripts, since pull_request_target executes PR-controlled input in base-repo context.
Addressed Issues:
Fixes #1441
AI Usage Disclosure:
We encourage contributors to use AI tools responsibly when creating Pull Requests. While AI can be a valuable aid, it is essential to ensure that your contributions meet the task requirements, build successfully, include relevant tests, and pass all linters. Submissions that do not meet these standards may be closed without warning to maintain the quality and integrity of the project. Please take the time to understand the changes you are proposing and their impact. AI slop is strongly discouraged and may lead to banning and blocking. Do not spam our repos with AI slop.
Check one of the checkboxes below:
I have used the following AI models and tools: Codex, Claude
Checklist
Summary by CodeRabbit