Skip to content

(fix): show missing recommended standalone tests in HTML #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chetan-rathore merged 1 commit into from
Oct 5, 2026
Merged

(fix): show missing recommended standalone tests in HTML #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions common/acs_test_framework_runner/report_ui_browser_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,19 +728,20 @@ def _run_page(
"READ-WRITE-CHECK-BLK-DEVICES | Mandatory | Compliant || " +
"CAPSULE-UPDATE | Mandatory | Not Compliant (Not Run) || " +
"PSCI | Recommended | Compliant || SMBIOS | Recommended | Compliant || " +
"NETWORK-BOOT | Recommended | Not Compliant (Not Run) || " +
"RUNTIME-DEV-MAP | Recommended | Not Compliant (Not Run) || " +
"RESERVED-MEMORY-MAP | Mandatory | Not Compliant (Not Run) || " +
"Future component | Future requirement | " +
"Partner review pending: <keep this detail>",
"Standalone must add only missing Mandatory components to its compliance table");
expect(!complianceValues.some(function (value) {
return value.indexOf("NETWORK-BOOT") >= 0;
}),
"A missing Recommended component must remain in the SRS summary only");
"Standalone must include missing Mandatory and Recommended components " +
"once in registry order while preserving each compliance value");
expect(complianceRows.every(function (row) {
return !row.hasAttribute("data-acs-row-status");
}) && document.documentElement.scrollWidth <=
document.documentElement.clientWidth + 1,
"Standalone compliance rows must remain outside filters without overflow");
expect(window.getComputedStyle(compliancePanel).borderLeftColor ===
expect(complianceRows.length === 11 &&
window.getComputedStyle(compliancePanel).borderLeftColor ===
window.getComputedStyle(compliancePanel).borderTopColor &&
window.getComputedStyle(complianceRows[0].cells[0]).boxShadow.indexOf(
"22, 163, 74") >= 0 &&
Expand All @@ -749,8 +750,14 @@ def _run_page(
window.getComputedStyle(complianceRows[4].cells[0]).boxShadow.indexOf(
"220, 38, 38") >= 0 &&
window.getComputedStyle(complianceRows[7].cells[0]).boxShadow.indexOf(
"220, 38, 38") >= 0 &&
window.getComputedStyle(complianceRows[8].cells[0]).boxShadow.indexOf(
"220, 38, 38") >= 0 &&
window.getComputedStyle(complianceRows[9].cells[0]).boxShadow.indexOf(
"220, 38, 38") >= 0 &&
window.getComputedStyle(complianceRows[10].cells[0]).boxShadow.indexOf(
"100, 116, 139") >= 0,
"Standalone must use red rails for failed and mandatory-not-run results, " +
"Standalone must use red rails for Not Compliant rows, " +
"with a neutral future-status fallback");
var select = document.querySelector(".acs-control select");
expect(select && select.previousElementSibling.textContent === "Jump to test case" &&
Expand All @@ -767,8 +774,12 @@ def _run_page(
expect(document.body.getAttribute("data-jump-worked") === "true" && select.value === "",
"Test-case jump selection must navigate and reset");
}
expect(document.querySelectorAll(".acs-case-overview").length === 2,
"Every standalone case must use the shared context card");
expect(document.querySelectorAll(".acs-case-overview").length === 2 &&
select.options.length === 3 &&
document.querySelector(".acs-compact-summary-total").textContent ===
"2 suite-reported tests" &&
document.querySelector(".acs-status-filter.info").textContent === "All outcomes 2",
"Missing compliance entries must not add result cards, jump targets, or test outcomes");
var firstOverview = document.querySelector(".acs-case-overview");
expect(firstOverview.querySelector(".acs-case-eyebrow").textContent === "Test case" &&
firstOverview.querySelector(".acs-case-title").textContent === "ping_test",
Expand Down Expand Up @@ -1393,7 +1404,11 @@ def main() -> int:
"Suite_Name: Mandatory : Capsule Update_compliance":
"Not Compliant: not run",
"Suite_Name: Recommended : NETWORK_BOOT_compliance":
"Not Run",
"Not Compliant: not run",
"Suite_Name: Recommended : RUNTIME_DEV_MAP_compliance":
"Not Compliant: not run",
"Suite_Name: Mandatory : RESERVED_MEMORY_MAP_compliance":
"Not Compliant: not run",
"Suite_Name: Recommended : PSCI_compliance": "Compliant",
"Suite_Name: Recommended : SMBIOS_compliance": "Compliant",
"Suite_Name: Future requirement : Future component_compliance":
Expand All @@ -1415,6 +1430,7 @@ def main() -> int:
},
{"Test_case": "psci_check", "Test_suite": "PSCI"},
{"Test_case": "SmbiosTable", "Test_suite": "SMBIOS"},
{"Test_case": "SmbiosTable", "Test_suite": "SMBIOS"},
{"Test_case": "Future component", "Test_suite": "Future suite"},
],
}
Expand All @@ -1440,6 +1456,10 @@ def main() -> int:
"ACS Results Summary": {
"Suite_Name: Mandatory : Capsule Update_compliance":
"Not Compliant: not run",
"Suite_Name: Recommended : RUNTIME_DEV_MAP_compliance":
"Not Compliant: not run",
"Suite_Name: Recommended : NETWORK_BOOT_compliance":
"Not Compliant: not run",
}
}
}), encoding="utf-8")
Expand Down
8 changes: 4 additions & 4 deletions common/log_parser/generate_acs_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,8 +685,8 @@ def _standalone_rows(merged_data, records):
if not rows:
return rows

# Keep a missing Mandatory component visible in the existing Standalone
# compliance table without creating an empty result report for it.
# Keep missing Mandatory and Recommended components visible in the existing
# Standalone compliance table without creating empty result reports for them.
for canonical in included_order:
registry_entry = registry_by_name.get(canonical, {})
requirement_key = registry_entry.get("requirement_key", canonical)
Expand All @@ -695,8 +695,8 @@ def _standalone_rows(merged_data, records):
if identity in seen or not record or not record.get("not_run"):
continue
if (
record["requirement"] != "Mandatory" or
record["compliance"] != "Not Compliant"
record["requirement"] not in {"Mandatory", "Recommended"} or
record["compliance"] not in {"Not Compliant", "Not Run"}
):
continue
missing_record = {**record, "component": canonical}
Expand Down
Loading