Skip to content

fix(val): correct page-table walk stride after partial top level #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chetan-rathore merged 1 commit into from
Oct 6, 2026
Merged

fix(val): correct page-table walk stride after partial top level #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion val/src/acs_mmu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ val_mmu_check_for_entry(uint64_t addr)

/* update level and remaining VA bits to resolve */
++this_level;
bits_remaining -= bits_at_this_level;
bits_remaining -= bits_per_level;
bits_at_this_level = bits_per_level;
}
/* execution should don't reach here */
Expand Down
4 changes: 2 additions & 2 deletions val/src/acs_pgt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ uint64_t *val_find_pte(pgt_descriptor_t pgt_desc, uint64_t virtual_address)
/* Move to the next level translation table */
tt_base_phys = val64 & (((0x1ull << (ias - page_size_log2)) - 1) << page_size_log2);
++this_level;
bits_remaining -= bits_at_this_level;
bits_remaining -= bits_per_level;
bits_at_this_level = bits_per_level;
}
}
Expand Down Expand Up @@ -755,7 +755,7 @@ uint64_t val_pgt_get_attributes(pgt_descriptor_t pgt_desc, uint64_t virtual_addr
}
tt_base_phys = val64 & (((0x1ull << (ias - page_size_log2)) - 1) << page_size_log2);
++this_level;
bits_remaining -= bits_at_this_level;
bits_remaining -= bits_per_level;
bits_at_this_level = bits_per_level;
}
}
Expand Down
Loading