Skip to content

ci: bump dtolnay/rust-toolchain from 1.95.0 to 1.120.0 #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: bump dtolnay/rust-toolchain from 1.95.0 to 1.120.0 #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:
uses: actions/checkout@v7

- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@1.95.0
uses: dtolnay/rust-toolchain@1.120.0

@codacy-production codacy-production Bot Sep 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

This update is problematic for several reasons:

  1. Invalid Action Reference: The dtolnay/rust-toolchain action typically does not use semantic version tags like @1.120.0 for the action itself (usually @master or @stable). Using an invalid reference will cause the GitHub Action to fail to initialize. To pin the toolchain version, use the toolchain input parameter instead.
  2. MSRV Guard Violation: This job is a guard for the project's MSRV. Bumping it raises the minimum requirement without a corresponding update to Cargo.toml, meaning you are no longer testing your actual minimum supported version.
  3. Security Risk: Pinning to a mutable tag (1.120.0) is a security risk. It is a best practice to pin actions to a specific 40-character commit SHA to prevent supply chain attacks.


- name: Setup Rust cache
uses: Swatinem/rust-cache@v2
Expand Down
Loading