deps: Raise libtiff minimum from 4.0 (late 2011) to 4.1 (late 2019) - #5414
Open
lgritz wants to merge 2 commits into
Open
deps: Raise libtiff minimum from 4.0 (late 2011) to 4.1 (late 2019)#5414lgritz wants to merge 2 commits into
lgritz wants to merge 2 commits into
Conversation
Still well over our "3-5 years back" guidelines for supporting dependencies. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Raises the minimum supported libTIFF version from 4.0 to 4.1.
Changes:
- Enforces libTIFF 4.1 at configuration and compile time.
- Updates compression handling and Deflate linkage.
- Removes obsolete compatibility paths and updates documentation.
Critical finding: CI jobs still use TIFF_BUILD_VERSION=4.0.0 with local TIFF builds, causing failures against the new version guard. Update those jobs to libTIFF 4.1+ or remove them.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/tiff.imageio/tiffoutput.cpp |
Updates libTIFF compatibility logic and Exif handling. |
src/tiff.imageio/tiffinput.cpp |
Raises the minimum version and updates compression mappings. |
src/tiff.imageio/CMakeLists.txt |
Adds Deflate linkage. |
src/cmake/externalpackages.cmake |
Raises the required libTIFF version. |
INSTALL.md |
Documents the new minimum dependency. |
Suppressed comments (1)
src/cmake/externalpackages.cmake:106
- This minimum is not propagated to installed static-package consumers:
src/cmake/Config.cmake.in:33still callsfind_dependency(TIFF)without a version. A consumer can therefore resolve libtiff 4.0 even though this build now requires 4.1, leaving an unsupported dependency configuration undetected. Please make the exported config require TIFF 4.1 as well.
VERSION_MIN 4.1
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| checked_find_package (TIFF REQUIRED | ||
| VERSION_MIN 4.0 | ||
| VERSION_MIN 4.1 |
Collaborator
Author
There was a problem hiding this comment.
Good catch, Copilot! Fixing.
Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still well over our "3-5 years back" guidelines for supporting dependencies.