doc: add Testing.md - #5420
Open
jinhgkim wants to merge 1 commit into
Open
Conversation
Used LLM to write the first draft and to cross-check the accuracy of the final version against the codebase. The draft was far too verbose, and cutting it down to something people would actually read took me quite a bit of time. Assisted-by: Claude Code / claude-opus-5 Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
Collaborator
Author
|
I wrote it in a way that makes sense to me, but am not sure if it would make sense to others as well. Feedback welcome. |
jinhgkim
commented
Aug 22, 2026
Comment on lines
77
to
81
| - For platform-specific diffs, add a variant ref (e.g. `out-win.txt`) rather | ||
| than overwriting | ||
| - Be conservative loosening image diff thresholds — use the minimum needed | ||
| - Check uploaded CI artifacts before changing references when local | ||
| reproduction is unclear |
Collaborator
Author
There was a problem hiding this comment.
In theory, we could drop these as they now live in Testing.md, and the coding assistant will read Testing.md as stated on line 75, BUT it may not prioritize those points as heavily as before. If we want to remove redundancy, we should remove it, and if we want those critical points to be prioritized by the agent, we should keep them. Let me know what you think, @lgritz.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4760.
Replaced
testsuite/TESTSUITE-README.mdwith a more complete version atdocs/dev/Testing.md.Used LLM to write the first draft and to cross-check the accuracy of the final version against the codebase. The draft was far too verbose, and cutting it down to something people would actually read took me quite a bit of time.
Assisted-by: Claude Code / claude-opus-5
Tests
No test needed.
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.