board: record PR #1241 post-merge (arc entry + LATEST_STATE) - #1242
Conversation
Hygiene-only PR — generates no further entry (termination clause). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCfrD5y19cvFc4AoyydXYv
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used all 3 included reviews currently available. Your 49 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d30d16bc-43dd-4c39-b33c-3fe2386e175e) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d4cf84bff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `FacetCascade::hi_distance` / `lo_distance` now read `tz((a ^ b) & AXIS_BYTES) | ||
| / 16` off the `u128` instead of gathering a six-byte chain and walking it: |
There was a problem hiding this comment.
When a state consumer implements the formula recorded here, a difference in tier 0 has 32 trailing zero bits, so the documented division returns 2 rather than a shared-axis prefix of 0. The merged implementation correctly uses (trailing_zeros() - 32) / 16; record that subtraction (or an equivalent right shift past the classid) so this mandatory state summary does not prescribe the wrong distance calculation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Correct — the summary dropped the − 32 that the merged shared_axis has ((x.trailing_zeros() - 32) / 16); as written it would prescribe prefix 2 for a tier-0 divergence. Fixed in the follow-up hygiene PR: LATEST_STATE now records (tz((a ^ b) & AXIS_BYTES) − 32) / 16 and says why the offset is load-bearing.
Generated by Claude Code
| `FacetCascade::hi_distance` / `lo_distance` now read `tz((a ^ b) & AXIS_BYTES) | ||
| / 16` off the `u128` instead of gathering a six-byte chain and walking it: | ||
| 12.5 → 5.8 ns for both axes, bit-identical over 64K pairs, disable-verified. | ||
| No public type added or removed; two private consts + one private `const fn`. |
There was a problem hiding this comment.
The merged facet.rs adds two private const fns, tier_byte_mask and shared_axis, not one; the arc entry later in this same change even refers to the doc-coverage warning on both helpers. Correct this inventory so readers relying on LATEST_STATE.md receive an accurate summary of the implementation delta.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Correct — two private const fns (tier_byte_mask, shared_axis), not one. LATEST_STATE fixed in the follow-up hygiene PR.
Generated by Claude Code
| (`folded_axis_prefix_matches_the_loop_at_every_position`) compares against | ||
| the loop it replaced at every divergence tier on both axes plus the | ||
| identical case. Board: `E-FORMAT-SLOT-FOLD-IS-THE-SAME-OP-AS-THE-VL-DESCENT-1`. | ||
| 2 files, 3 commits (the first cut re-folded the gathered chain into a |
There was a problem hiding this comment.
The local first-parent range d5d3f7ab^1..d5d3f7ab^2 contains four PR commits (95e2863, ce6664e, 76bb237, and 45c5199), so this permanent per-PR history undercounts the merged commits as three. Update the count to four so the arc inventory agrees with the repository history it documents.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Correct — git log d5d3f7ab^1..d5d3f7ab^2 is four commits (95e2863, ce6664e, 76bb237, 45c5199). The arc inventory is append-only, so the entry gets a dated correction line naming all four rather than an in-place rewrite; follow-up hygiene PR.
Generated by Claude Code
…he recorded formula, two const fns not one, four commits not three Belated review on the merged hygiene PR; all three verified against facet.rs and git log d5d3f7a^1..d5d3f7a^2. Arc entry corrected by a dated append, LATEST_STATE fixed in place with the review cited. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCfrD5y19cvFc4AoyydXYv
…ssid offset, two const fns, four commits) board: three Codex corrections on #1242 (−32 classid offset, two const fns, four commits)
…tail sites The fold-once epiphany carried the same missing offset Codex caught in the summaries (#1242/#1243); the sibling session found it uncorrected in the durable record. And the '12 hand-rolled tail sites' figure was attributed — counted, it is 23. Dated append under the entry, nothing rewritten. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCfrD5y19cvFc4AoyydXYv
The revert in b08db9b shipped a semantically equivalent chain fold (by-ref, tiers[n] indexed, bool axis selector) rather than the code #1242 replaced. The probe's arm A is the ORIGINAL shared6 verbatim, so the 1.72 ns measurement belonged to the original, not to what was shipped. Restored byte-for-byte from 95e2863^: const fn shared6(a: [u8; 6], b: [u8; 6]) -> u8 pub const fn hi_distance(self, other: Self) -> u8 // by-value again pub const fn lo_distance(self, other: Self) -> u8 Verified identical by diff against that commit. This also undoes the unintended public-signature change (&self/&Self -> self/Self), so the API is exactly what it was before #1242. The inverted test oracle and the doc comment stay; probe's shipped-reference call sites follow. 1425 tests green; fmt + clippy clean; probe: oracle green on every workload, A 1.83 / C 3.95 on random, slope +80.9%. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HScwwezRdMxFfTs3WLG19d
2 participants
Hygiene-only: the post-merge
PR_ARC_INVENTORY.mdentry andLATEST_STATE.mdline for #1241 (d5d3f7ab). No code, no contract inventory delta. Per the termination clause this PR generates no further entry.🤖 Generated with Claude Code
https://claude.ai/code/session_01DCfrD5y19cvFc4AoyydXYv
Generated by Claude Code